PIPE2D-1046: Singular matrix in spectral extraction #270
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PaulPrice
force-pushed
the
tickets/PIPE2D-506
branch
2 times, most recently
from
7e3852c to
594775c
Compare
Wavelength needs to be in double precision in order to preserve the precision in the measurements, but other quantities (esp. flux) don't need double precision, and datamodel I/O has been reverted to single-precision for these to save disk space. This commit adapts to these changes.
Helps to have access to the workspace in python to understand problems.
It should not be possible to fail an assertion merely because a user provided data with the wrong sizes.
The matrix for spectral extraction can be singular if two fibers rely on the same single pixel. This manifests in solveSymmetricTridiagonal as denominator=0, which leads to all values in the solution being NaN, due to the back-propagation. Instead, when we get denominator=0, treat that element like it doesn't have any data (set diagonal=1, offDiag=0, answer=0) and set the solution for that element to NAN.
PaulPrice
force-pushed
the
tickets/PIPE2D-1046
branch
from
ea6a987 to
32670fa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.