Add a Joke Skill #318
Open
Add a Joke Skill #318
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Inhishonor
commented
May 12, 2025
Stypox
requested changes
Jul 2, 2025
Stypox
requested changes
Jul 4, 2025
There was a problem hiding this comment.
Actually, now that I think of it, these jokes are only in English. Maybe we could use another API that has multilanguage jokes? This one has a handful languages https://jokeapi.dev/, I couldn't find ones with more languages. Then the JokeInfo should return isAvailable()==true only if the language is supported by the API.
Makes an api call to https://v2.jokeapi.dev/joke/Any or if locale is "en": https://official-joke-api.appspot.com/random_joke Co-authored-by: Stypox <[email protected]>
|
I took care of that, and it is know calling that url. I enabled safe-mode by default, but am not sure if that needs to happen? Also, I found the jokes from the first api to be better, so I added an if block, to call the first api if the language is english, or the other one if that language is available. Other than that should be good to go. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This skill makes an api call to https://official-joke-api.appspot.com.
Most of the jokes are bad puns. :)
Satisfies request 2 in #66.