Skip to content

Fix semaphore reuse validation error by waiting on all fences #90

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
0xKitKoi wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix semaphore reuse validation error by waiting on all fences #90

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e51a94b
Fix semaphore reuse validation error by waiting on all fences
0xKitKoi Jul 12, 2025
d438668
Added Error Checking as per CodeRabbit
0xKitKoi Jul 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions Walnut/src/Walnut/Application.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -663,6 +663,18 @@ namespace Walnut {
wd->ClearValue.color.float32[3] = clear_color.w;
if (!main_is_minimized)
FrameRender(wd, main_draw_data);


// Wait for all fences to avoid semaphore reuse issues in multi-viewport mode
for (uint32_t i = 0; i < g_MainWindowData.ImageCount; i++)
{
ImGui_ImplVulkanH_Frame* frame = &g_MainWindowData.Frames[i];
if (frame->Fence != VK_NULL_HANDLE)
{
VkResult err = vkWaitForFences(g_Device, 1, &frame->Fence, VK_TRUE, UINT64_MAX);
check_vk_result(err);
}
}

// Update and Render additional Platform Windows
if (io.ConfigFlags & ImGuiConfigFlags_ViewportsEnable)
Expand Down