Skip to content

Rebuild checked paths from the repository root #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Pixnop merged 1 commit into from
Sep 2, 2026
Merged

Rebuild checked paths from the repository root #48

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions contrib/grafana/check-dashboard.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,11 +23,11 @@
REPO = pathlib.Path(__file__).resolve().parent.parent.parent


def inside_repo(path):
try:
return pathlib.Path(path).resolve().is_relative_to(REPO)
except OSError:
return False
def repo_path(path):
"""The argument rebuilt from the repository root, so what gets opened is
always REPO/<something inside it>. Raises ValueError for anything outside,
OSError for anything that does not exist."""
return REPO / pathlib.Path(path).resolve(strict=True).relative_to(REPO)


def panels(dashboard):
Expand Down Expand Up @@ -94,12 +94,12 @@ def main(paths):

failed = False
for path in paths:
if not inside_repo(path):
try:
problems = check(repo_path(path))
except ValueError:
print(f"{path}: outside the repository, refusing to read it")
failed = True
continue
try:
problems = check(path)
except (OSError, json.JSONDecodeError) as e:
print(f"{path}: {e}")
failed = True
Expand Down
Loading