Keep the quality gate green after the dashboard wave - #47
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two gate conditions tripped on the dashboard PR's new code. check-dashboard.py now refuses any path outside the repository before opening it, which settles the S8707 finding and is the right contract anyway for a script that exists to check this repo's dashboards. And contrib/ plus tools/ join the coverage exclusions: operator tooling and the mutation script are exercised by being run, not by the unit suites, and their uncovered lines were dragging new-code coverage under the 80% bar the same way the ModSystems used to.