Add fftfreq import to runtests.jl#76
Open
theralavineela wants to merge 1 commit into
Open
Conversation
Member
|
Hey @theralavineela , thanks for your Pr You find this error in like test cases were failing ??? |
Author
|
Yes sir , I encountered the issue while running the test suite locally — some of the test cases were failing due to UndefVarError: fftfreq not defined. After investigating, I noticed that fftfreq was being used without explicitly importing it. I reproduced this while running the tests on Julia v1.12.5. Adding the explicit import from AbstractFFTs resolved the issue locally and allowed the tests to run. Please let me know if you would like me to test this on any other Julia versions as well. |
Member
Author
|
yeah sure sir ,thank you for the clarification :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Fourier tests used
fftfreqwithout explicitly importing the modulethat defines it. With Julia ≥1.10 this results in:
This PR:
fftfreqfrom AbstractFFTs in the test suiteThis makes the dependency explicit and allows the test suite to run on
modern Julia versions without altering any functionality.