Skip to content

Add fftfreq import to runtests.jl#76

Open
theralavineela wants to merge 1 commit into
StingraySoftware:mainfrom
theralavineela:patch-1
Open

Add fftfreq import to runtests.jl#76
theralavineela wants to merge 1 commit into
StingraySoftware:mainfrom
theralavineela:patch-1

Conversation

@theralavineela
Copy link
Copy Markdown

The Fourier tests used fftfreq without explicitly importing the module
that defines it. With Julia ≥1.10 this results in:

UndefVarError: fftfreq not defined

This PR:

  • Imports fftfreq from AbstractFFTs in the test suite

This makes the dependency explicit and allows the test suite to run on
modern Julia versions without altering any functionality.

@kashish2210
Copy link
Copy Markdown
Member

kashish2210 commented Mar 11, 2026

Hey @theralavineela , thanks for your Pr You find this error in like test cases were failing ???
And in what exact version of Julia??

@theralavineela
Copy link
Copy Markdown
Author

Yes sir , I encountered the issue while running the test suite locally — some of the test cases were failing due to UndefVarError: fftfreq not defined. After investigating, I noticed that fftfreq was being used without explicitly importing it.

I reproduced this while running the tests on Julia v1.12.5. Adding the explicit import from AbstractFFTs resolved the issue locally and allowed the tests to run.

Please let me know if you would like me to test this on any other Julia versions as well.

@kashish2210
Copy link
Copy Markdown
Member

kashish2210 commented Mar 12, 2026

Oh ohaky may be we can consider this as refactor along with once ci in #74 will be updated we can test this also along with #73

@theralavineela
Copy link
Copy Markdown
Author

yeah sure sir ,thank you for the clarification :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants