Refactoring simple FSM order_execution_round.py#114
Draft
Karrenbelt wants to merge 5 commits intomainfrom
Draft
Conversation
Karrenbelt
commented
Jul 5, 2025
Comment on lines
+266
to
+267
| # what do we return here?? | ||
| return True |
Collaborator
Author
There was a problem hiding this comment.
This is the bug fix i referred to. Previously, only when the double if was hit this function returned a boolean (hence, implicitly returned None previously when the nested if statements weren't hit)
Base automatically changed from
chore/simple_fsm_logging
to
feat/improve_logging
July 10, 2025 09:45
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is mainly a refactor PR, as the logic was overly convoluted, making it unnecessarily hard to understand what was going on. All logic is still the same, including exception logic and all other branching behaviors, with one notable exception. There is a bug fix in this PR in the
_handle_cancelledpath:CANCELLEDorder with zero fill fell through and returnedNone(falsy), unintentionally treated as failurereturn Truewhenfilled_amt == 0. Need to confirm this now is preserving intent, or otherwise returnFalseIt also includes several improvements to the logging, which was the original reason I looked into this (and the other) behaviours of the simple FSM skill.