Add Spanish Localizations #149

pauljohanneskraft · 2025-06-04T07:34:15Z

Add Spanish Localizations

♻️ Current situation & Problem

We finally received the translations to now support Spanish inside this app! Please make sure to check the attached file during review, just to make sure I didn't mess up during copying over! I also needed to create a new xcstrings file for the InfoPlist strings - this is the way it worked with .strings files, so not sure if it still works this way!

ENGAGEHF-iOS_Spanish.xlsx

⚙️ Release Notes

Add a bullet point list summary of the feature and possible migration guides if this is a breaking change so this section can be added to the release notes.
Include code snippets that provide examples of the feature implemented or links to the documentation if it appends or changes the public interface.

📚 Documentation

Please ensure that you properly document any additions in conformance to Spezi Documentation Guide.
You can use this section to describe your solution, but we encourage contributors to document your reasoning and changes using in-line documentation.

✅ Testing

Please ensure that the PR meets the testing requirements set by CodeCov and that new functionality is appropriately tested.
This section describes important information about the tests and why some elements might not be testable.

Code of Conduct & Contributing Guidelines

By creating and submitting this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

I agree to follow the Code of Conduct and Contributing Guidelines.

Copilot

Pull Request Overview

This PR adds Spanish localizations for the app’s Info.plist usage descriptions, moves those keys into a new .xcstrings file, and updates the project configuration to include the new file and locale.

Introduce InfoPlist.xcstrings (with accompanying license) containing English and Spanish translations for all usage-description keys.
Remove hardcoded privacy strings from Info.plist so they are sourced from the new JSON-based localization.
Update the Xcode project (.pbxproj) to reference InfoPlist.xcstrings, add es to known regions, and enable Swift string extraction.

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

File	Description
ENGAGEHF/Supporting Files/InfoPlist.xcstrings.license	Add MIT license header for the new `.xcstrings` resource.
ENGAGEHF/Supporting Files/InfoPlist.xcstrings	Add JSON entries for English and Spanish localizations of usage strings.
ENGAGEHF/Supporting Files/Info.plist	Remove inline `<key>`/`<string>` usage-description entries.
ENGAGEHF.xcodeproj/project.pbxproj	Reference `InfoPlist.xcstrings`, register `es` locale, set build flags.

Comments suppressed due to low confidence (1)

ENGAGEHF/Supporting Files/InfoPlist.xcstrings:13

New Spanish localizations have been added; consider adding or updating tests (e.g., UI or snapshot tests) to verify that these InfoPlist keys load correctly under the 'es' locale.

"es" : {

Copilot · 2025-06-04T08:14:05Z

ENGAGEHF/Supporting Files/InfoPlist.xcstrings

+        "en" : {
+          "stringUnit" : {
+            "state" : "translated",
+            "value" : "The ENGAGE-HF app uses the step count to demonstrate Spezi's integration with HealthKit."


[nitpick] NSHealthUpdateUsageDescription uses the same message as NSHealthShareUsageDescription. Consider providing distinct messages to clearly differentiate between sharing and updating HealthKit data.

Actually a good point; @pauljohanneskraft & @NikolaiMadlener we should adjust this.

I didn't think this was super pressing, so I didn't include this in the updated file - we should probably include the updated text(s) with all the other missing keys within the Spezi ecosystem.

NikolaiMadlener

Thanks for copying all the translations over @pauljohanneskraft !
Looks really good.

ENGAGEHF/Resources/Localizable.xcstrings

PSchmiedmayer

Thank you for working on this!

Might make sense to let the translation team know about any missing strings. Wondering if we should merge it first, then merge the Spezi Account elements, and then see if we have any missing pieces?

I also suspect that we will eventually need to also translate some parts of Spezi Account? Might be best to spot all of that in the app itself once we test the localization?

PSchmiedmayer · 2025-06-04T18:29:43Z

ENGAGEHF/Supporting Files/InfoPlist.xcstrings

+        "en" : {
+          "stringUnit" : {
+            "state" : "translated",
+            "value" : "The ENGAGE-HF app uses the step count to demonstrate Spezi's integration with HealthKit."


Actually a good point; @pauljohanneskraft & @NikolaiMadlener we should adjust this.

Copilot

Pull Request Overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.

Comments suppressed due to low confidence (1)

ENGAGEHF/Supporting Files/InfoPlist.xcstrings:1

Corrected Spanish translation of 'Expires in' to be more natural: 'Caduca en:' would be more appropriate than 'Caduca el:'

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

ENGAGEHF/Resources/Localizable.xcstrings

Copilot

Pull Request Overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

ENGAGEHF/Supporting Files/InfoPlist.xcstrings

Copilot · 2025-10-14T20:12:42Z

ENGAGEHF/Resources/Localizable.xcstrings

+        "es" : {
+          "stringUnit" : {
+            "state" : "translated",
+            "value" : "Su cuenta fue desactivada."


The Spanish translation for 'Your account was deactivated\nby your study coordinator.' appears to be missing the second part about the study coordinator. The original English includes information about who deactivated the account, which should be preserved in the Spanish translation.

Suggested change

"value" : "Su cuenta fue desactivada."

"value" : "Su cuenta fue desactivada\npor su coordinador de estudio."

codecov · 2025-10-14T20:55:36Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.13%. Comparing base (dfbfdea) to head (ab96de1).

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #149      +/-   ##
==========================================
+ Coverage   78.93%   79.13%   +0.21%     
==========================================
  Files         153      153              
  Lines         982      982              
==========================================
+ Hits          775      777       +2     
+ Misses        207      205       -2

see 1 file with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dfbfdea...ab96de1. Read the comment docs.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

PSchmiedmayer

Looks solid, thank you for all the improvements here! Happy to see this merged soon 👍

PSchmiedmayer · 2025-10-14T22:17:40Z

ENGAGEHF.xcodeproj/project.pbxproj

 /* End PBXTargetDependency section */

 /* Begin XCBuildConfiguration section */
+		2FEE10302998C89C000822E1 /* Test */ = {


I don't think we need the TEST scheme here; we have removed it from other apps as well.

PSchmiedmayer · 2025-10-14T22:18:27Z

ENGAGEHF.xcodeproj/project.pbxproj

We might want to update some of the dependencies here; some of them added a Spanish localization in the recent releases.

PSchmiedmayer · 2025-10-31T00:39:09Z

@pauljohanneskraft Updated some dependencies in the other branch to pull them in here as well 👍

PSchmiedmayer · 2025-12-05T04:28:14Z

@pauljohanneskraft Updated this PR as well; might be good to merge at some point as well 👍

pauljohanneskraft added 3 commits June 4, 2025 09:31

Add spanish localization

3c9ea98

Add license to InfoPlist.xcstrings

f5faf5b

Fix one string

b926d6e

pauljohanneskraft requested review from NikolaiMadlener, PSchmiedmayer and Copilot June 4, 2025 08:12

pauljohanneskraft self-assigned this Jun 4, 2025

pauljohanneskraft added the enhancement New feature or request label Jun 4, 2025

pauljohanneskraft added this to ENGAGE-HF Planning Board Jun 4, 2025

Copilot AI reviewed Jun 4, 2025

View reviewed changes

NikolaiMadlener approved these changes Jun 4, 2025

View reviewed changes

ENGAGEHF/Resources/Localizable.xcstrings Show resolved Hide resolved

ENGAGEHF/Resources/Localizable.xcstrings Show resolved Hide resolved

ENGAGEHF/Resources/Localizable.xcstrings Show resolved Hide resolved

ENGAGEHF/Resources/Localizable.xcstrings Outdated Show resolved Hide resolved

PSchmiedmayer reviewed Jun 4, 2025

View reviewed changes

pauljohanneskraft added 2 commits October 14, 2025 21:40

Merge branch 'main' into spanish

59b934f

Update localizations

4089ca3

pauljohanneskraft requested a review from Copilot October 14, 2025 19:56

Copilot AI reviewed Oct 14, 2025

View reviewed changes

ENGAGEHF/Resources/Localizable.xcstrings Show resolved Hide resolved

Add Contacts localization

ab96de1

pauljohanneskraft requested review from PSchmiedmayer and Copilot October 14, 2025 20:12

Copilot AI reviewed Oct 14, 2025

View reviewed changes

PSchmiedmayer approved these changes Oct 14, 2025

View reviewed changes

Merge branch 'main' into spanish

a3505f5

Merge branch 'main' into spanish

b3b1961

	"value" : "Su cuenta fue desactivada."
	"value" : "Su cuenta fue desactivada\npor su coordinador de estudio."

Uh oh!

Add Spanish Localizations #149

Are you sure you want to change the base?

Add Spanish Localizations #149

Uh oh!

Conversation

pauljohanneskraft commented Jun 4, 2025

Add Spanish Localizations

♻️ Current situation & Problem

⚙️ Release Notes

📚 Documentation

✅ Testing

Code of Conduct & Contributing Guidelines

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Copilot AI Jun 4, 2025

Choose a reason for hiding this comment

Uh oh!

PSchmiedmayer Jun 4, 2025

Choose a reason for hiding this comment

Uh oh!

pauljohanneskraft Jun 11, 2025

Choose a reason for hiding this comment

Uh oh!

NikolaiMadlener left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

PSchmiedmayer left a comment

Choose a reason for hiding this comment

Uh oh!

PSchmiedmayer Jun 4, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Uh oh!

Copilot AI Oct 14, 2025

Choose a reason for hiding this comment

Uh oh!

codecov bot commented Oct 14, 2025

Codecov Report

Uh oh!

PSchmiedmayer left a comment

Choose a reason for hiding this comment

Uh oh!

PSchmiedmayer Oct 14, 2025

Choose a reason for hiding this comment

Uh oh!

PSchmiedmayer Oct 14, 2025

Choose a reason for hiding this comment

Uh oh!

PSchmiedmayer commented Oct 31, 2025

Uh oh!

PSchmiedmayer commented Dec 5, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants