Skip to content

v1.0.0#1

Merged
AntoTG merged 12 commits intomainfrom
develop
Mar 30, 2026
Merged

v1.0.0#1
AntoTG merged 12 commits intomainfrom
develop

Conversation

@AntoTG
Copy link
Copy Markdown
Member

@AntoTG AntoTG commented Mar 30, 2026

  • Multi-vault stVault monitoring support.
  • Prometheus metrics for vault health, balances, utilization, PDG, and withdrawal queue.
  • Discord alerting with per-vault/per-alert cooldown behavior.
  • Grafana dashboard build pipeline and import-ready JSON.
  • Mainnet + Hoodi network support.

@kilo-code-bot
Copy link
Copy Markdown

kilo-code-bot bot commented Mar 30, 2026

Code Review Summary

Status: 10 Issues Found | Recommendation: Address before merge

Overview

Severity Count
CRITICAL 0
WARNING 10
SUGGESTION 0
Issue Details (click to expand)

WARNING

File Line Issue
src/config.js 189 FORCED_REBALANCE_THRESHOLD_BP parsing is not strict (`parseInt(...)
src/notifications/discord.js 55 Precision/overflow risk from converting wei bigint to Number before formatting inactive ETH.
src/notifications/discord.js 73 Precision loss risk from converting unfinalizedAssetsWei bigint to Number before formatting.
src/notifications/discord.js 74 Precision loss risk from converting availableBalanceWei bigint to Number before formatting/deficit calculation.
src/monitors/healthMonitor.js 16 Health-factor math converts wei bigint values to Number, which can introduce threshold-affecting rounding drift at large magnitudes.
src/monitors/vaultMonitor.js 307 nodeOperatorBalance tuple shape is assumed without validation; malformed return can propagate undefined and fail later during metric conversion.
src/monitors/vaultMonitor.js 332 Number(healthShortfallShares) can lose integer precision for large share values in metrics output.
src/monitors/vaultMonitor.js 337 Number(liabilityShares) can lose integer precision for large share values in metrics output.
src/monitors/vaultMonitor.js 339 Number(mintingCapacityShares) can lose integer precision for large share values in metrics output.
src/index.js 49 Number(s.unfinalizedRequests) can lose precision for large counters; logs/alerts should preserve bigint fidelity.
Other Observations (not in diff)

No additional issues outside diff hunks.

Files Reviewed (1 files)
  • static/terminal.png - 0 issues

Change Summary

Incremental diff since 288ef548f90f6e2c347130667be1ef6ae4eb6607 only changes static/terminal.png (binary image). No new code changes were introduced in this increment, so prior findings remain active with no newly introduced issues.

Fix these issues in Kilo Cloud

Comment thread src/notifications/discord.js
Comment thread src/notifications/discord.js
Comment thread src/notifications/discord.js
Comment thread src/config.js
Comment thread src/monitors/healthMonitor.js
Comment thread src/monitors/vaultMonitor.js
Comment thread src/monitors/vaultMonitor.js
Comment thread src/monitors/vaultMonitor.js
Comment thread src/monitors/vaultMonitor.js
Comment thread src/index.js
@AntoTG AntoTG merged commit 1368549 into main Mar 30, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants