-
Notifications
You must be signed in to change notification settings - Fork 42
Remove required_ from core & added tests to ensure both are working #169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
0728b81
to
c5007db
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the PR! Everything looks great, but can you fix the linting of the code?
|
@agam1092005 Can you fix the linting so that we can merge this PR? Thanks!! |
Sorry, but unable to understand & find the issue |
Hey there! No worries if "linting" sounded confusing! Basically, we just need to clean up the code's formatting so it's neat and follows standard style guidelines. Tirith uses a tool called
That’s it! Black will automatically fix the formatting for you, so you don’t have to worry about the details. Let me know if you need help with anything else! 😊 |
@agam1092005 Have you been able to fix it? |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good, but only one thing left: backward compatibility. Could you modify the code in a way that it will still accept the old required_provider
when the user provided that? Thanks
Solved issue #166
Kindly check if issue is solved and merge the PR
Agampreet Singh