Don't add a MSVC-style flag if not using MSVC on windows #213
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes builds on Windows when, for instance, one is using `clang` on top of `MSys2`; and in a more generic way than the pre-existing solution. For expected return values of the `get_argument_syntax()` method, see https://mesonbuild.com/Reference-tables.html#compiler-ids
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently when building on Windows, the only time an MSVC-style flag isn't defined is if the build system is using
gcc. This causes problems when building with almost anything that isn'tgccormsvc, i.e.clang.With this PR, the MSVC-style flag is only defined when
msvc(or something that accepts MSVC-style syntax) is being used.For expected return values of the
get_argument_syntax()method, see https://mesonbuild.com/Reference-tables.html#compiler-idsThe method requires
meson >= 0.49, but aspython-rtmidiitself (currently) requiresmeson >= 0.64, this should be acceptable.