Remove noise_levels
and templates
from quality metric deps
#4080
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the moment, the
quality_metrics
extension requiresnoise_levels
andtemplates
to be computed before we can compute quality metrics. However,sd_ratio
depends ontemplates
.snr
depends onnoise_levels
.So these requirements are a bit over the top. This PR moves the extension existence check to the
compute_metric
functions, and adds a nice function_has_required_extensions
which deals with the error message. Does not work for the amplitude metrics, since they can use spike_amplitudes or amplitude_scalings.Now, the quality metrics extension has no dependencies, and will compute some spike-train related metrics if you give it an extension-less analyzer.
We had discussed introducing a
UnitMetric
class or something. I think this is simpler for now!