Templates.is_scaled > Templates.is_in_uV #4036
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I was just commenting on this deprecation. We hadn't officially discussed deprecation strategy for |
|
This is great, thanks Sam. |
alejoe91
reviewed
Jul 17, 2025
alejoe91
approved these changes
Jul 22, 2025
|
I propose to merge this now because #3923 will need some fixes after, so the sooner the better. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This needed to be done after #3794.
At the moement is is a simple replace in the entire code.
There are many return_scaled to be changed in return_in_uV but @zm711 already started to change some in #4033.
So lets wait #4033 to be merged first and then lets continue working on this.
I think we will need to make some logic for readi backward compatible Templates saved before 0.103.0