Merged
Conversation
- Test job now installs only pytest/pytest-cov, other deps from pyproject.toml - Build sdist job now installs only 'build' tool, deps from [build-system] - Removes CYTHONIZE=1 and --no-build-isolation (not needed) - Simplifies maintenance: dependencies defined once in pyproject.toml
vad
force-pushed
the
cleanup-dependencies
branch
from
90ce496 to
55a1214
Compare
w3lib 2.0 removed str_to_unicode which is used in scrapely/__init__.py. Pin to w3lib<2.0 in both pyproject.toml and requirements.txt until code is migrated to w3lib 2.0 API.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.