Skip to content

SONARJAVA-6513 Add a skill for new rule creation#5697

Merged
romainbrenguier merged 4 commits into
masterfrom
romain/new-rule-skill
Jun 24, 2026
Merged

SONARJAVA-6513 Add a skill for new rule creation#5697
romainbrenguier merged 4 commits into
masterfrom
romain/new-rule-skill

Conversation

@romainbrenguier

@romainbrenguier romainbrenguier commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

This should help agent implementing a new rule, and in particular Nigel's tools.

Part of


Summary by Gitar

  • Documentation:
    • Added comprehensive guidelines for implementing new rules, including metadata generation, file structure, and dependency management.
    • Included instructions for updating its/ruling/ and its/autoscan/ test suites.

This will update automatically on new commits.

This should help agent implementing a new rule, and in particular Nigel's tools.
@hashicorp-vault-sonar-prod hashicorp-vault-sonar-prod Bot changed the title Add a skill for new rule creation SONARJAVA-6513 Add a skill for new rule creation Jun 23, 2026
@hashicorp-vault-sonar-prod

hashicorp-vault-sonar-prod Bot commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

SONARJAVA-6513

@romainbrenguier romainbrenguier marked this pull request as ready for review June 23, 2026 15:14
Comment thread .claude/skills/new-rule/SKILL.md Outdated

@NoemieBenard NoemieBenard left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, just a comment about ruling tests

Comment thread .claude/skills/new-rule/SKILL.md Outdated
- Run JavaAgenticWayProfileTest before creating a PR
- Update ruling tests in `its/ruling/` and autoscan tests in `its/autoscan` after implementing the rule.
- These tests verify the rule against real-world Java projects.
- Note that running this tests locally is difficult, so they are usually updated by looking at the logs of the failing CI actions

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For ruling, I am not sure if the issue can be understood from the log, usually it is necessary to download the zip report generated during the build and look at the diff.

@romainbrenguier romainbrenguier enabled auto-merge (squash) June 24, 2026 13:14
@gitar-bot

gitar-bot Bot commented Jun 24, 2026

Copy link
Copy Markdown
Code Review ✅ Approved

Implements a dedicated skill for new rule creation to assist automated agents with rule generation. No issues found.

Options

Auto-apply is off → Gitar will not commit updates to this branch.
Display: compact → Showing less information.

Comment with these commands to change:

Auto-apply Compact
gitar auto-apply:on         
gitar display:verbose         

Was this helpful? React with 👍 / 👎 | Gitar

@sonarqube-next

Copy link
Copy Markdown

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
0 Dependency risks
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@romainbrenguier romainbrenguier merged commit 72ebc0c into master Jun 24, 2026
15 checks passed
@romainbrenguier romainbrenguier deleted the romain/new-rule-skill branch June 24, 2026 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants