SONARJAVA-6330 Lower rule S8692's severity and do not raise on System.currentTimeMillis()

its/ruling/src/test/resources/commons-beanutils/java-S8692.json

@@ -1,30 +1,4 @@
 {
-"commons-beanutils:commons-beanutils:src/test/java/org/apache/commons/beanutils2/BeanUtilsBenchCase.java": [
-186,
-190,
-198,
-202,
-219,
-223,
-231,
-235,
-252,
-256,
-264,
-268,
-285,
-289,
-297,
-301,
-318,
-322,
-330,
-334,
-352,
-356,
-364,
-368
-],
 "commons-beanutils:commons-beanutils:src/test/java/org/apache/commons/beanutils2/BeanUtilsTestCase.java": [
 149
 ],
@@ -37,25 +11,7 @@
 "commons-beanutils:commons-beanutils:src/test/java/org/apache/commons/beanutils2/DynaRowSetTestCase.java": [
 403
 ],
-"commons-beanutils:commons-beanutils:src/test/java/org/apache/commons/beanutils2/PropertyUtilsBenchCase.java": [
-175,
-179,
-187,
-191,
-208,
-212,
-220,
-224,
-241,
-245,
-253,
-257
-],
-"commons-beanutils:commons-beanutils:src/test/java/org/apache/commons/beanutils2/TestResultSet.java": [
-66
-],
 "commons-beanutils:commons-beanutils:src/test/java/org/apache/commons/beanutils2/converters/DateConverterTestBase.java": [
-105,
 379
 ],
 "commons-beanutils:commons-beanutils:src/test/java/org/apache/commons/beanutils2/converters/NumberConverterTestBase.java": [

its/ruling/src/test/resources/eclipse-jetty/java-S8692.json

@@ -1,40 +1,11 @@
 {
-"org.eclipse.jetty:jetty-project:jetty-http/src/test/java/org/eclipse/jetty/http/HttpFieldsTest.java": [
-139
-],
-"org.eclipse.jetty:jetty-project:jetty-server/src/test/java/org/eclipse/jetty/server/HttpServerTestBase.java": [
-693,
-744,
-801,
-835,
-1008,
-1010,
-1296,
-1298,
-1715,
-1743
-],
 "org.eclipse.jetty:jetty-project:jetty-util/src/test/java/org/eclipse/jetty/util/DateCacheTest.java": [
-78,
 79,
 80,
 82,
-83,
-85,
 86,
 87,
-89,
 90,
 91
-],
-"org.eclipse.jetty:jetty-project:jetty-util/src/test/java/org/eclipse/jetty/util/thread/SchedulerTest.java": [
-84,
-90,
-106,
-112,
-122,
-128,
-149,
-170
 ]
 }

its/ruling/src/test/resources/sonar-server/java-S8692.json

@@ -6,9 +6,7 @@
 254
 ],
 "org.sonarsource.sonarqube:sonar-server:src/test/java/org/sonar/server/batch/ProjectDataLoaderMediumTest.java": [
-609,
-620,
-621
+609
 ],
 "org.sonarsource.sonarqube:sonar-server:src/test/java/org/sonar/server/component/ComponentCleanerServiceTest.java": [
 137
@@ -70,11 +68,7 @@
 "org.sonarsource.sonarqube:sonar-server:src/test/java/org/sonar/server/issue/TransitionServiceTest.java": [
 95
 ],
-"org.sonarsource.sonarqube:sonar-server:src/test/java/org/sonar/server/issue/index/IssueIndexDebtTest.java": [
-76
-],
 "org.sonarsource.sonarqube:sonar-server:src/test/java/org/sonar/server/issue/index/IssueIndexTest.java": [
-107,
 1254
 ],
 "org.sonarsource.sonarqube:sonar-server:src/test/java/org/sonar/server/issue/index/IssueIndexerTest.java": [
@@ -98,26 +92,9 @@
 "org.sonarsource.sonarqube:sonar-server:src/test/java/org/sonar/server/measure/custom/ws/SearchActionTest.java": [
 183
 ],
-"org.sonarsource.sonarqube:sonar-server:src/test/java/org/sonar/server/measure/index/ProjectMeasuresIndexTest.java": [
-1384,
-1393,
-1402
-],
-"org.sonarsource.sonarqube:sonar-server:src/test/java/org/sonar/server/measure/index/ProjectMeasuresIndexTextSearchTest.java": [
-293
-],
-"org.sonarsource.sonarqube:sonar-server:src/test/java/org/sonar/server/measure/ws/ComponentTreeActionTest.java": [
-144,
-146
-],
 "org.sonarsource.sonarqube:sonar-server:src/test/java/org/sonar/server/organization/TestDefaultOrganizationProvider.java": [
 39
 ],
-"org.sonarsource.sonarqube:sonar-server:src/test/java/org/sonar/server/permission/index/PermissionIndexerTester.java": [
-41,
-48,
-55
-],
 "org.sonarsource.sonarqube:sonar-server:src/test/java/org/sonar/server/platform/ws/DbMigrationStatusActionTest.java": [
 72
 ],
@@ -128,9 +105,6 @@
 "org.sonarsource.sonarqube:sonar-server:src/test/java/org/sonar/server/platform/ws/MigrateDbActionTest.java": [
 63
 ],
-"org.sonarsource.sonarqube:sonar-server:src/test/java/org/sonar/server/projecttag/ws/SearchActionTest.java": [
-116
-],
 "org.sonarsource.sonarqube:sonar-server:src/test/java/org/sonar/server/qualityprofile/ws/InheritanceActionTest.java": [
 257,
 270
@@ -149,10 +123,6 @@
 289,
 290
 ],
-"org.sonarsource.sonarqube:sonar-server:src/test/java/org/sonar/server/search/BaseDocTest.java": [
-109,
-135
-],
 "org.sonarsource.sonarqube:sonar-server:src/test/java/org/sonar/server/test/index/TestIndexerTest.java": [
 120
 ],

java-checks-test-sources/default/src/test/java/checks/tests/SystemClockCheckSample.java

@@ -62,8 +62,7 @@ void testInjectSystemClock() {
 
   @Test
   void testSystemMethods() {
-    long currentTimeMillis = System.currentTimeMillis(); // Noncompliant {{Do not use the system clock in tests.}}
-//                           ^^^^^^^^^^^^^^^^^^^^^^^^^^
+    long currentTimeMillis = System.currentTimeMillis(); // Compliant: currentTimeMillis is typically used to measure elapsed time in tests
     long currentTimeNanos = System.nanoTime(); // Compliant: nanoTime is typically used to measure elapsed time in tests
     assertTrue(currentTimeMillis < currentTimeNanos);
   }

java-checks/src/main/java/org/sonar/java/checks/tests/SystemClockCheck.java

@@ -48,11 +48,6 @@ public class SystemClockCheck extends AbstractMethodDetection {
       .names("systemUTC", "systemDefaultZone", "system")
       .withAnyParameters()
       .build(),
-    MethodMatchers.create()
-      .ofTypes("java.lang.System")
-      .names("currentTimeMillis")
-      .addWithoutParametersMatcher()
-      .build(),
     MethodMatchers.create()
       .ofTypes("java.util.Calendar")
       .names("getInstance")

sonar-java-plugin/src/main/resources/org/sonar/l10n/java/rules/java/S8692.json

@@ -11,15 +11,15 @@
     "datetime",
     "tests"
   ],
-  "defaultSeverity": "Critical",
+  "defaultSeverity": "Major",
   "ruleSpecification": "RSPEC-8692",
   "sqKey": "S8692",
   "scope": "Tests",
   "quickfix": "infeasible",
   "code": {
     "impacts": {
-      "MAINTAINABILITY": "HIGH",
-      "RELIABILITY": "MEDIUM"
+      "MAINTAINABILITY": "MEDIUM",
+      "RELIABILITY": "LOW"
     },
     "attribute": "TRUSTWORTHY"
   }