fix: bounds check for gltf indices#34
Open
anzzyspeaksgit wants to merge 1 commit into
Open
Conversation
This prevents panic: index out of range when a GLTF file contains primitive indices pointing outside the bound of vertex attributes array.
Owner
|
Oh, hey, thanks a lot - I appreciate the PR! But I think the line endings or formatting are different or something, because the diff shows complete deletion of the contents of |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #19
Added a bounds check for indices read from GLTF files. Previously, if a GLTF file contained primitive indices pointing outside the bound of the vertex attributes array (for example, if interleaved data generated by qmuntal/gltf was improperly exported as described in #19), it would panic with
index out of range.Now, it properly returns an error
invalid gltf: index <x> out of bounds for vertex data length <y>instead of panicking.