Skip to content

Add generate-scope-file-inventory#18

Open
dessens0 wants to merge 5 commits intomainfrom
generate_scope_file_inventory
Open

Add generate-scope-file-inventory#18
dessens0 wants to merge 5 commits intomainfrom
generate_scope_file_inventory

Conversation

@dessens0
Copy link
Copy Markdown
Contributor

No description provided.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Mar 25, 2025

Test Results

32 tests  ±0   32 ✅ ±0   17s ⏱️ +2s
 1 suites ±0    0 💤 ±0 
 1 files   ±0    0 ❌ ±0 

Results for commit a6f8b14. ± Comparison against base commit 458fc79.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Mar 25, 2025

Sigrid maintainability feedback

⚠️ Your code did not improve maintainability towards your objective of 3.5 stars

Show details

Sigrid compared your code against the baseline of 2025-08-19.

👍 What went well?

You fixed or improved 0 refactoring candidates.

👎 What could be better?

Unfortunately, 4 refactoring candidates were introduced or got worse.

Risk System property Location
🔴 Duplication
(Introduced)
objectives-report/sigrid_api_client.py line 20-40
generate-scope-file-inventory/sigrid_api_client.py line 20-40
🟠 Unit Size
(Introduced)
generate-scope-file-inventory/generate-scope-file-inventory.py
generate-scope-file-inventory.py
🟡 Unit Complexity
(Introduced)
generate-scope-file-inventory/generate-scope-file-inventory.py
generate-scope-file-inventory.py
🟡 Unit Interfacing
(Introduced)
generate-scope-file-inventory/sigrid_api_client.py
SigridApiClient.init(sigridURL,customer,token)

📚 Remaining technical debt

0 refactoring candidates didn't get better or worse, but are still present in the code you touched.

View this system in Sigrid to explore your technical debt

⭐️ Sigrid ratings

System property System on 2025-08-19 Before changes New/changed code
Volume 5.5 N/A N/A
Duplication 4.4 N/A 2.8
Unit Size 4.5 N/A 1.7
Unit Complexity 3.6 N/A 1.5
Unit Interfacing 3.0 N/A 4.8
Module Coupling 3.1 N/A 5.5
Component Independence 5.5 N/A N/A
Component Entanglement N/A N/A N/A
Maintainability 4.3 N/A 3.1

💬 Did you find this feedback helpful?

We would like to know your thoughts to make Sigrid better.
Your username will remain confidential throughout the process.


View this system in Sigrid

@MichielCuijpers
Copy link
Copy Markdown
Member

asking @dennis-sig or @bruno-oliveira for a second pair of eyes

@dessens0 dessens0 self-assigned this Aug 28, 2025
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Sep 5, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
16.0% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants