Skip to content

Remove objectives report#120

Closed
maximjanssen wants to merge 1 commit intoremove-report-generatorfrom
remove-objectives-report
Closed

Remove objectives report#120
maximjanssen wants to merge 1 commit intoremove-report-generatorfrom
remove-objectives-report

Conversation

@maximjanssen
Copy link
Copy Markdown
Member

No description provided.

Copilot AI review requested due to automatic review settings April 21, 2026 14:34
@sonarqubecloud
Copy link
Copy Markdown

@github-actions
Copy link
Copy Markdown

Test Results

0 tests  ±0   0 ✅ ±0   0s ⏱️ ±0s
0 suites ±0   0 💤 ±0 
0 files   ±0   0 ❌ ±0 

Results for commit abe29e5. ± Comparison against base commit e78faa4.

@github-actions
Copy link
Copy Markdown

Sigrid maintainability feedback

💭️ You did not change any files that are analyzed by Sigrid.


View this system in Sigrid

Sigrid Open Source Health feedback

✅ You achieved your objective of having no open source vulnerabilities.

✅ You achieved your objective of having no open source libraries with license issues.

Show details

Sigrid compared your code against the baseline of 2026-04-21.


View this system in Sigrid

Sigrid Security feedback (Beta)

✅ You achieved your objective of having no high-severity security findings

Show details

Sigrid CI for Security is currently in Beta. The documentation contains more information on its current state and known limitations.

Sigrid compared your code against the baseline of 2026-04-21 12:01 UTC.

  • ❌ means this finding fails your objective.
  • ⚠️ means a finding exists, but is not severe enough to fail your objective.
  • ✅ means everything is fine.

👍 What went well?

You did not introduce any security findings during your changes, great job!

You fixed 1 security findings.

Risk Meets objective? File Finding
🟠 objectives-report/sigrid_api_client.py:30 The application was found passing in a non-literal value to the urllib methods which issue requests

😑 You have remaining security findings

You have 19 open security findings.
You can view these findings in Sigrid.


View this system in Sigrid

@maximjanssen maximjanssen marked this pull request as draft April 21, 2026 14:37
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request removes the deprecated objectives-report integration (Python scripts, README, and its dependency list) from the repository.

Changes:

  • Deletes the objectives report generator scripts and helper modules.
  • Removes the objectives-report-specific requirements.txt.
  • Removes the objectives-report README/documentation.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Show a summary per file
File Description
objectives-report/sigrid_api_client.py Removes the objectives-report-specific Sigrid API client implementation.
objectives-report/requirements.txt Removes objectives-report Python dependencies (e.g., charting libs).
objectives-report/objectives_report.py Removes the CLI entrypoint that generated SVG charts for objectives reporting.
objectives-report/objectives.py Removes objectives evaluation/trend calculation logic used by the report script.
objectives-report/README.md Removes documentation for the deprecated objectives report integration.
Comments suppressed due to low confidence (2)

objectives-report/objectives_report.py:1

  • Removing the objectives report integration will break the repo's container packaging/entrypoints unless references are cleaned up too. Please remove/update the Dockerfile steps that copy /integrations/objectives-report, install its requirements, and add it to PATH, and also remove objectives_report.py from the supported command list in integrations.sh.
    objectives-report/README.md:1
  • After removing this integration, please also update the repository-level docs that still mention it (e.g., the root README.md still lists objectives-report/ under “Available integrations”). Otherwise the documentation will contain broken links/outdated guidance.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants