Skip to content

Add AQ Knowledge Distribution placeholders; add Division to treemap#104

Draft
ricardovogel wants to merge 6 commits intomainfrom
aq-knowledge-metric
Draft

Add AQ Knowledge Distribution placeholders; add Division to treemap#104
ricardovogel wants to merge 6 commits intomainfrom
aq-knowledge-metric

Conversation

@ricardovogel
Copy link
Copy Markdown
Member

@ricardovogel ricardovogel commented Mar 18, 2026

Added placeholders for knowledge distribution specifically.
Additionally: added "division" as a possible grouped_by placeholder in the treemap

@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 18, 2026

Test Results

232 tests  ±0   232 ✅ ±0   23s ⏱️ -1s
  1 suites ±0     0 💤 ±0 
  1 files   ±0     0 ❌ ±0 

Results for commit 0a845f6. ± Comparison against base commit 7fee42a.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 18, 2026

Sigrid maintainability feedback

✅ You wrote maintainable code and achieved your objective of 3.0 stars.

Show details

Sigrid compared your code against the baseline of 2026-03-18.

👍 What went well?

You fixed or improved 0 refactoring candidates.

👎 What could be better?

Unfortunately, 6 refactoring candidates were introduced or got worse.

Risk System property Location
🔴 Duplication
(Introduced)
report-generator/src/report_generator/generator/data_models/portfolio/knowledge_distribution_portfolio.py line 23-43
report-generator/src/report_generator/generator/data_models/portfolio/architecture_portfolio.py line 23-43
🔴 Duplication
(Introduced)
report-generator/src/report_generator/generator/data_models/portfolio/knowledge_distribution_portfolio.py line 58-66
report-generator/src/report_generator/generator/data_models/portfolio/architecture_portfolio.py line 58-66
🟠 Module Coupling
(Worsened)
report-generator/src/report_generator/generator/placeholders/base.py
🟡 Unit Size
(Introduced)
report-generator/src/report_generator/generator/placeholders/base.py
ParameterizedPlaceholder.resolve(report)
🟡 Unit Complexity
(Introduced)
report-generator/src/report_generator/generator/placeholders/base.py
ParameterizedPlaceholder.resolve(report)
🟡 Unit Interfacing
(Introduced)
report-generator/src/report_generator/generator/placeholders/images/treemap_image.py
ArchitectureMetricPortfolioTreemapPlaceholder.value(metric,parameter,additional_parameter)

📚 Remaining technical debt

12 refactoring candidates didn't get better or worse, but are still present in the code you touched.

View this system in Sigrid to explore your technical debt

⭐️ Sigrid ratings

System property System on 2026-03-18 Before changes New/changed code
Volume 5.0 N/A N/A
Duplication 4.4 5.5 4.2
Unit Size 4.4 4.8 4.7
Unit Complexity 3.5 3.7 3.5
Unit Interfacing 2.9 2.1 2.2
Module Coupling 3.2 2.2 2.3
Component Independence 5.5 N/A N/A
Component Entanglement N/A N/A N/A
Maintainability 4.2 3.7 3.4

💬 Did you find this feedback helpful?

We would like to know your thoughts to make Sigrid better.
Your username will remain confidential throughout the process.


View this system in Sigrid

Sigrid Open Source Health feedback

✅ You achieved your objective of having no open source vulnerabilities.

✅ You achieved your objective of having no open source libraries with license issues.

Show details

Sigrid compared your code against the baseline of 2026-03-18.


View this system in Sigrid

@ricardovogel ricardovogel self-assigned this Mar 18, 2026
@ricardovogel ricardovogel changed the title Add AQ Knowledge Distribution placeholders Add AQ Knowledge Distribution placeholders; add Division to treemap Mar 19, 2026
@sonarqubecloud
Copy link
Copy Markdown

@maximjanssen maximjanssen self-assigned this Mar 19, 2026
Comment on lines -73 to -76
| `PORTFOLIO_KNOWL_ABOVE_MARKET` | Percentage of systems scoring above market average (≥3.5 stars) on knowledge distribution quality. | |
| `PORTFOLIO_KNOWL_AVG_RATING` | Volume-weighted average knowledge distribution rating across all systems in the portfolio. | |
| `PORTFOLIO_KNOWL_BELOW_MARKET` | Percentage of systems scoring below market average (<2.5 stars) on knowledge distribution quality. | |
| `PORTFOLIO_KNOWL_MARKET_AVERAGE` | Percentage of systems scoring market average (2.5-3.5 stars) on knowledge distribution quality. | |
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@maximjanssen
Did you implement average rating for the other AQ metrics too, or only the treemap?
Either way, I think the docs here are incorrect

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ricardovogel I was halfway through making these changes when Floris and I decided to put this MR on hold until the v1 changes are done. That's why everything is a bit out of sync now.

@maximjanssen maximjanssen marked this pull request as draft March 24, 2026 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants