Restrict adapter calls to registered agents only

[yrong]

No description provided.

[codecov]

Codecov Report

❌ Patch coverage is 83.33333% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 78.80%. Comparing base (e7fa333) to head (0137696).

Files with missing lines	Patch %	Lines
...ntracts/src/l2-integration/SnowbridgeL2Adaptor.sol	0.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1730      +/-   ##
==========================================
+ Coverage   75.20%   78.80%   +3.59%     
==========================================
  Files          24       24              
  Lines         996     1000       +4     
  Branches      186      188       +2     
==========================================
+ Hits          749      788      +39     
+ Misses        223      186      -37     
- Partials       24       26       +2     

Flag	Coverage Δ
solidity	78.80% <83.33%> (+3.59%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[claravanstaden]

Suggested change

	Agent(payable(msg.sender)).GATEWAY() == GATEWAY,
	"Caller is not a registered Gateway Agent"
	IGatewayV2(GATEWAY).isAgent(msg.sender),
	"Caller is not a registered Gateway Agent"

Otherwise someone can deploy a contract that returns the expected GATEWAY address from a GATEWAY() function without actually being a real Agent.

[claravanstaden]

Added test in #1733 to demonstrate.

[yrong]

Nice catch!

It seems we don't have IGatewayV2(GATEWAY).isAgent(msg.sender) implemented yet? To achieve this, I assume we would need an additional mapping from agent address to ID in storage?

snowbridge/contracts/src/storage/CoreStorage.sol

Line 15 in 8412aaf

mapping(bytes32 agentID => address) agents;