Gauge Proxy V3 Initial Review#142
Open
auroter wants to merge 25 commits into
Open
Conversation
added 7 commits
November 3, 2021 23:39
…tes for specific token
…ation, fixed a bug where poke messed up a users votes
auroter
marked this pull request as ready for review
January 14, 2022 00:28
saito-sv
reviewed
Jan 14, 2022
saito-sv
previously approved these changes
Jan 14, 2022
saito-sv
left a comment
saito-sv
left a comment
There was a problem hiding this comment.
Not need to address my comments, but would great for consistency.
saito-sv
self-requested a review
January 14, 2022 01:56
fuzzylemma
reviewed
Jan 15, 2022
|
Tests dont use |
fuzzylemma
reviewed
Jan 21, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Created GaugeProxyV3 which contains bug fixes for voting, deprecating vote, poking, and constructing with governance. Created GaugeProxyV3 test script which tests new GaugeProxyV3 fixes along with soft migration.
This is a draft pull request for initial review. The next step will be to modularize the test and use this code as the basis for a soft migration script which does not rely on impersonation.