Added assert() to Signal#253
Open
Vetnech wants to merge 1 commit into
Open
Conversation
Added a check to make sure :Once, :ConnectOnce and :Connect receive a function.
Owner
|
Is there a reason the type-checker didn't catch this issue for you? |
Author
I only received an internal error when the signal was later fired (when the module was looping through the connections and calling each connected function?) which could be confusing as it doesn't traceback to the wrong connection. It personally took a while because the connection without any functions passed was made at a section I had half finished before moving onto a different script. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a check to make sure :Once, :ConnectOnce and :Connect receive a function so that users do not get confused by the naturally occurring error when they forget to pass a function (like me) or pass something else.