Fix full-scale config with multiple environments#219
Open
Blaadam wants to merge 1 commit into
Open
Conversation
The documentation states that there is support for multiple environments but doesn't actually check whether the logconfig can be used in the existing environment and throws an error.
mirsdemo
approved these changes
May 3, 2026
mirsdemo
left a comment
mirsdemo
left a comment
There was a problem hiding this comment.
Great PR!
This correctly addresses the logic issue and enables full-scale configurations to be used as documented.
Unsure why this hasn't been merged yet, though it's a necessary patch.
Without this, defining both a Dev and Prod environment causes a crash in the Dev environment, as the loop asserts on the Prod block before checking if the IDs match.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The documentation states that there is support for multiple environments but doesn't actually check whether the logconfig can be used in the existing environment and throws an error.