Fix CameraShakerInstance:UpdateShake's timestep#6
Open
kennethloeffler wants to merge 3 commits into
Open
Conversation
|
Can not attest to #4, but this updated code does not make the effect consistent regardless of FPS for me. |
try adding this from line 154 - 156, it worked for me |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CameraShakerInstance:UpdateShakeuses a variable timestep to perform the update, causing players with low FPS and players using FPS unlockers to experience very pronounced shaking. This PR changesCameraShakerInstance:UpdateShaketo use a fixed timestep so that the effect is consistent regardless of FPSCloses #4