Show account icon in activity browsing#53
Conversation
|
TODO: bump |
JimHugelier
left a comment
JimHugelier
left a comment
There was a problem hiding this comment.
General:
- Some files could be split up (like dataverse.js?)
- All calls during initial load are replicated for each account, group?
- Calls during initial load grouped by account are done sequentially, slowing down initial load.
- No actual way to 'search' in titles/descriptions?
Open issue when a note is coupled to a lead that doesn't have a 'regarding' yet, note is not coupled to anything? Waiting for fix here before continuing.
| useEffect(() => { | ||
| const missing = [...new Set( | ||
| (notes ?? []).map(noteAccountId).filter((id) => id && !(id in accountImages)) | ||
| const wanted = [...new Set( |
There was a problem hiding this comment.
Why this change? This now refetches all logo's on every search, but logo's don't change that much right? Also, logo is already retrieved when adding it as a regarding filter, so why fetch it again on clicking search?
There was a problem hiding this comment.
This was added to ensure the account icon is shown when filtering only by attendee, but indeed not necessary to fetch again on clicking search. See commit b7b75d2 with an alternative solution.
There was a problem hiding this comment.
Like discussed F2F, will add a cache for the account images.
1cf81b9 to
7390e76
Compare
Collaboration task