Maint/sync with upstream #1
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nal-id Add optional support for ExternalId when assuming role.
…non-conflicting names.
This should resolve problems when rolling back a deploy after the coalesce phase. Previously after coalesce the old production target group would no longer be on the rule, and thus trying to coalesce back on the production target group would fail. As of 0.3.0 this would then cause deployomat to completely undeploy the service (previously it would cause the cancel to fail). Obviously a bad outcome. Now since coalesce should always succeed provided the rule is a forward rule, rollback after coalesce should succeed as well.
I've been running into frequent errors where AWS AutoScaling will claim that the target group does not exist, when it very much does. Currently, that will fail the entire deploy. This retry will hopefully handle that eventual consistency error.
Also document why we're doing our own retry logic.
AWS says We are reaching out to you regarding an upcoming change that affects your usage of tags with Elastic Load Balancing (ELB) API calls. On June 1, 2023, we will be adding an additional layer of security to ELB ‘Create*' API calls where API callers must have explicit access to add tags in their Identity and Access Management (IAM) policy [1]. Currently, access to attach tags was implicitly granted with access to 'Create*' APIs. We detected that you have used IAM policies that are affected by this change. To prevent issues, we recommend you update your IAM policy configuration to allow access to 'elasticloadbalancing:AddTags' when using 'Create*' API calls. We will be allowing 'Create*' API calls with the current policy to be accepted until August 30, 2023. After this date, the 'Create*' API call will fail and return an error if the the attribute is specified and permission is not granted.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.