Skip to content

check if all required fields have been entered before allowing a save #80

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

check if all required fields have been entered before allowing a save #80

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion components/component-actions/componentTemplates/componentActions.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
<div class="simplycode-part" data-simply-field="deleted" data-simply-content="attributes" data-simply-attributes="data-deleted">
<div class="simplycode-part-header">
<div class="simplycode-tabs">
<input class="simplycode-tab" data-simply-field="action" placeholder="Action name, eg getItemList">
<input class="simplycode-tab" required data-simply-field="action" placeholder="Action name, eg getItemList">
<label class="simplycode-tab">
<input type="radio" name="actionEditor" checked value="code" data-simply-field="editor">
<span>Code</span>
Expand Down
2 changes: 1 addition & 1 deletion components/component-body-html/componentTemplates/componentBodyHtml.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
<div class="simplycode-part" data-simply-field="deleted" data-simply-content="attributes" data-simply-attributes="data-deleted">
<div class="simplycode-part-header">
<div class="simplycode-tabs">
<input class="simplycode-tab" data-simply-field="name" placeholder="Name">
<input class="simplycode-tab" required data-simply-field="name" placeholder="Name">
</div>
<div class="simplycode-options">
<button class="simplycode-button" draggable="true">Drag to move</button>
Expand Down
2 changes: 1 addition & 1 deletion components/component-builder-template/componentTemplates/componentBuilderTemplate.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
<div class="simplycode-part" data-simply-field="deleted" data-simply-content="attributes" data-simply-attributes="data-deleted">
<div class="simplycode-part-header">
<div class="simplycode-tabs">
<input class="simplycode-tab" data-simply-field="builder" placeholder="Builder name">
<input class="simplycode-tab" data-simply-field="builder" required placeholder="Builder name">
<label class="simplycode-tab">
<input type="radio" name="builderEditor" checked value="code" data-simply-field="editor">
<span>Code</span>
Expand Down
2 changes: 1 addition & 1 deletion components/component-commands/componentTemplates/componentCommands.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
<div class="simplycode-part" data-simply-field="deleted" data-simply-content="attributes" data-simply-attributes="data-deleted">
<div class="simplycode-part-header">
<div class="simplycode-tabs">
<input class="simplycode-tab" data-simply-field="command" placeholder="Command name, eg getItemList">
<input class="simplycode-tab" data-simply-field="command" required placeholder="Command name, eg getItemList">
<label class="simplycode-tab">
<input type="radio" name="commandEditor" checked value="code" data-simply-field="editor">
<span>Code</span>
Expand Down
2 changes: 1 addition & 1 deletion components/component-component-css/componentTemplates/componentComponentCss.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
<div class="simplycode-part" data-simply-field="deleted" data-simply-content="attributes" data-simply-attributes="data-deleted">
<div class="simplycode-part-header">
<div class="simplycode-tabs">
<input class="simplycode-tab" data-simply-field="name" placeholder="Name this CSS collection">
<input class="simplycode-tab" data-simply-field="name" required placeholder="Name this CSS collection">
</div>
<div class="simplycode-options">
<button class="simplycode-button" draggable="true">Drag to move</button>
Expand Down
2 changes: 1 addition & 1 deletion components/component-component-html/componentTemplates/componentComponentTemplate.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
<div class="simplycode-part" data-simply-field="deleted" data-simply-content="attributes" data-simply-attributes="data-deleted">
<div class="simplycode-part-header">
<div class="simplycode-tabs">
<input class="simplycode-tab" data-simply-field="component" placeholder="Component name">
<input class="simplycode-tab" data-simply-field="component" required placeholder="Component name">
<label class="simplycode-tab">
<input type="radio" name="actionEditor" checked value="code" data-simply-field="editor">
<span>Code</span>
Expand Down
2 changes: 1 addition & 1 deletion components/component-data-api/componentTemplates/componentDataApi.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
<div class="simplycode-part" data-simply-field="deleted" data-simply-content="attributes" data-simply-attributes="data-deleted">
<div class="simplycode-part-header">
<div class="simplycode-tabs">
<input class="simplycode-tab" data-simply-field="method" placeholder="API method name, eg getItemList">
<input class="simplycode-tab" data-simply-field="method" required placeholder="API method name, eg getItemList">
</div>
<div class="simplycode-options">
<button class="simplycode-button" draggable="true">Drag to move</button>
Expand Down
2 changes: 1 addition & 1 deletion components/component-data-sources/componentTemplates/componentDataSources.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
<div class="simplycode-part" data-simply-field="deleted" data-simply-content="attributes" data-simply-attributes="data-deleted">
<div class="simplycode-part-header">
<div class="simplycode-tabs">
<input class="simplycode-tab" data-simply-field="dataSource" placeholder="Data source name, eg itemList">
<input class="simplycode-tab" data-simply-field="dataSource" required placeholder="Data source name, eg itemList">
<label class="simplycode-tab" title="Load code is used to fetch the data source and render it in the list. Save code is used to gather data from the data source and save it back to where it came from.">
<input type="radio" checked name="dataSourceEditor" value="code" data-simply-field="editor">
<span>Load/Save</span>
Expand Down
2 changes: 1 addition & 1 deletion components/component-foot-html/componentTemplates/componentFootHtml.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
<div class="simplycode-part" data-simply-field="deleted" data-simply-content="attributes" data-simply-attributes="data-deleted">
<div class="simplycode-part-header">
<div class="simplycode-tabs">
<input class="simplycode-tab" data-simply-field="name" placeholder="Name">
<input class="simplycode-tab" data-simply-field="name" required placeholder="Name">
</div>
<div class="simplycode-options">
<button class="simplycode-button" draggable="true">Drag to move</button>
Expand Down
2 changes: 1 addition & 1 deletion components/component-head-html/componentTemplates/componentHeadHtml.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
<div class="simplycode-part" data-simply-field="deleted" data-simply-content="attributes" data-simply-attributes="data-deleted">
<div class="simplycode-part-header">
<div class="simplycode-tabs">
<input class="simplycode-tab" data-simply-field="name" placeholder="Name">
<input class="simplycode-tab" data-simply-field="name" required placeholder="Name">
</div>
<div class="simplycode-options">
<button class="simplycode-button" draggable="true">Drag to move</button>
Expand Down
2 changes: 1 addition & 1 deletion components/component-page-css/componentTemplates/componentPageCss.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
<div class="simplycode-part" data-simply-field="deleted" data-simply-content="attributes" data-simply-attributes="data-deleted">
<div class="simplycode-part-header">
<div class="simplycode-tabs">
<input class="simplycode-tab" data-simply-field="name" placeholder="Name this CSS collection">
<input class="simplycode-tab" data-simply-field="name" required placeholder="Name this CSS collection">
</div>
<div class="simplycode-options">
<button class="simplycode-button" draggable="true">Drag to move</button>
Expand Down
2 changes: 1 addition & 1 deletion components/component-page-template/componentTemplates/componentPageTemplate.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
<div class="simplycode-part" data-simply-field="deleted" data-simply-content="attributes" data-simply-attributes="data-deleted">
<div class="simplycode-part-header">
<div class="simplycode-tabs">
<input class="simplycode-tab" data-simply-field="page" placeholder="Page name">
<input class="simplycode-tab" data-simply-field="page" required placeholder="Page name">
<label class="simplycode-tab">
<input type="radio" name="actionEditor" checked value="code" data-simply-field="editor">
<span>Code</span>
Expand Down
2 changes: 1 addition & 1 deletion components/component-qunit-tests/componentTemplates/componentQUnitTests.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
<div class="simplycode-test" data-simply-field="deleted" data-simply-content="attributes" data-simply-attributes="data-deleted">
<div class="simplycode-test-header">
<div class="simplycode-tabs">
<input class="simplycode-tab" data-simply-field="name" placeholder="Test name">
<input class="simplycode-tab" data-simply-field="name" required placeholder="Test name">
</div>
<div class="simplycode-options">
<button class="simplycode-button" draggable="true">Drag to move</button>
Expand Down
2 changes: 1 addition & 1 deletion components/component-raw-api/componentTemplates/componentRawApi.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
<div class="simplycode-part" data-simply-field="deleted" data-simply-content="attributes" data-simply-attributes="data-deleted">
<div class="simplycode-part-header">
<div class="simplycode-tabs">
<input class="simplycode-tab" data-simply-field="method" placeholder="API method name, eg getItemList">
<input class="simplycode-tab" data-simply-field="method" required placeholder="API method name, eg getItemList">
</div>
<div class="simplycode-options">
<button class="simplycode-button" draggable="true">Drag to move</button>
Expand Down
2 changes: 1 addition & 1 deletion components/component-routes/componentTemplates/componentRoutes.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
<div class="simplycode-part" data-simply-field="deleted" data-simply-content="attributes" data-simply-attributes="data-deleted">
<div class="simplycode-part-header">
<div class="simplycode-tabs">
<input class="simplycode-tab" data-simply-field="name" placeholder="Name of the route">
<input class="simplycode-tab" data-simply-field="name" required placeholder="Name of the route">
<input class="simplycode-tab" data-simply-field="route" placeholder="#route/:variable">
</div>
<div class="simplycode-options">
Expand Down
2 changes: 1 addition & 1 deletion components/component-shortcuts/componentTemplates/componentShortcuts.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
<div class="simplycode-part" data-simply-field="deleted" data-simply-content="attributes" data-simply-attributes="data-deleted">
<div class="simplycode-part-header">
<div class="simplycode-tabs">
<input class="simplycode-tab" data-simply-field="shortcut" placeholder="shortcut-key">
<input class="simplycode-tab" data-simply-field="shortcut" required placeholder="shortcut-key">
<label class="simplycode-tab">
<input type="radio" name="actionEditor" checked value="code" data-simply-field="editor">
<span>Code</span>
Expand Down
2 changes: 1 addition & 1 deletion components/component-sorters/componentTemplates/componentSorters.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
<div class="simplycode-part" data-simply-field="deleted" data-simply-content="attributes" data-simply-attributes="data-deleted">
<div class="simplycode-part-header">
<div class="simplycode-tabs">
<input class="simplycode-tab" data-simply-field="sorter" placeholder="Sorter name, eg sortByDescription">
<input class="simplycode-tab" data-simply-field="sorter" required placeholder="Sorter name, eg sortByDescription">
</div>
<div class="simplycode-options">
<button class="simplycode-button" draggable="true">Drag to move</button>
Expand Down
2 changes: 1 addition & 1 deletion components/component-transformers/componentTemplates/componentTransformers.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
<div class="simplycode-part" data-simply-field="deleted" data-simply-content="attributes" data-simply-attributes="data-deleted">
<div class="simplycode-part-header">
<div class="simplycode-tabs">
<input class="simplycode-tab" data-simply-field="transformer" placeholder="Transformer name, eg itemNameFromId">
<input class="simplycode-tab" data-simply-field="transformer" required placeholder="Transformer name, eg itemNameFromId">
<label class="simplycode-tab" title="Render code transforms the data from what is stored into what the user sees. Extract takes the data as provided from the DOM and transforms it for storage">
<input type="radio" checked name="transformerEditor" value="code" data-simply-field="editor">
<span>Render/Extract</span>
Expand Down
15 changes: 15 additions & 0 deletions components/components-generic/commands/preSaveCheck.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
function(el) {
if (document.querySelector(":invalid")) {
editor.pageData.alerts.unshift({
"data-simply-template" : "error",
"message" : "Not all required fields have been filled out.",
"state" : "new"
});
document.querySelectorAll("details:has(:invalid)").forEach(function(item) {
item.setAttribute("open", true);
});
document.querySelector(":invalid:not(form)").focus();
return false;
}
return true;
}
Loading