feat(frontend/builder): add confirmation dialog for workspace file removal#12603
Draft
Abhi1992002 wants to merge 1 commit intodevfrom
Draft
feat(frontend/builder): add confirmation dialog for workspace file removal#12603Abhi1992002 wants to merge 1 commit intodevfrom
Abhi1992002 wants to merge 1 commit intodevfrom
Conversation
…moval When users remove a file from a file input in the builder, show a confirmation dialog since workspace file deletion is non-reversible. Only triggers for workspace uploads (onDeleteFile provided); base64 mode clears immediately as before.
Contributor
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
onDeleteFileprovided); base64/local mode clears immediately as beforeDialogmolecule with "Remove file" title, cancel/remove buttonsdefaultandcompactFileInput variantsChanges
FileInput.tsx: AddedshowDeleteConfirmstate,requestClear()gate function, and a reusabledeleteConfirmDialogelement rendered in both variant branchesTest plan
defaultandcompactFileInput variants