Skip to content

fix: 지원서-문서 연결 업데이트 오류 수정 #92

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hyotatoFrappuccino merged 1 commit into from
Sep 2, 2025
Merged

fix: 지원서-문서 연결 업데이트 오류 수정 #92

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions ...n/java/com/jobnote/domain/applicationformdocument/dto/ApplicationFormDocumentRequest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,10 +6,8 @@
import jakarta.validation.constraints.NotNull;

public record ApplicationFormDocumentRequest(
Long id,

@NotNull(message = "문서 ID는 null일 수 없습니다.")
Long documentId
Long id
) {
public ApplicationFormDocument toEntity(final ApplicationForm form, final Document document) {
return ApplicationFormDocument.builder()
Expand Down
11 changes: 7 additions & 4 deletions ...va/com/jobnote/domain/applicationformdocument/service/ApplicationFormDocumentService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ public Map<Long, List<DocumentSimpleResponse>> getAllSimpleGroupedByApplicationF
@Transactional
public void saveAll(final Long userId, final ApplicationForm form, final List<ApplicationFormDocumentRequest> requests) {
for (ApplicationFormDocumentRequest request : requests) {
Document document = getByIdOrThrow(request.documentId());
Document document = getByIdOrThrow(request.id());
document.validateOwner(userId);

ApplicationFormDocument entity = request.toEntity(form, document);
Expand All @@ -82,6 +82,9 @@ public void saveAll(final Long userId, final ApplicationForm form, final List<Ap
public void updateAll(final Long userId, final ApplicationForm form, final List<ApplicationFormDocumentRequest> requests) {
// 기존 연결된 문서 조회
List<ApplicationFormDocument> existsDocuments = getAllByApplicationFormId(userId, form.getId());
Set<Long> existsIds = existsDocuments.stream()
.map(document -> document.getDocument().getId())
.collect(Collectors.toSet());

// 요청 문서 ID 목록
Set<Long> requestsIds = requests.stream()
Expand All @@ -91,14 +94,14 @@ public void updateAll(final Long userId, final ApplicationForm form, final List<

// 삭제 : 기존 문서 중 요청에 없는 문서 삭제
for (ApplicationFormDocument document : existsDocuments) {
if (!requestsIds.contains(document.getId())) {
if (!requestsIds.contains(document.getDocument().getId())) {
delete(document);
}
}

// 신규 생성
// 신규 생성 : 새로운 id
for (ApplicationFormDocumentRequest req : requests) {
if (req.id() == null) {
if (!existsIds.contains(req.id())) {
saveAll(userId, form, List.of(req));
}
}
Expand Down
Loading