Skip to content

docs: 주석 작성 #90

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
hyotatoFrappuccino merged 5 commits into from
Sep 1, 2025
Merged

docs: 주석 작성 #90

hyotatoFrappuccino merged 5 commits into from
Sep 1, 2025

Conversation

@hyotatoFrappuccino
Copy link
Collaborator

@hyotatoFrappuccino hyotatoFrappuccino commented Sep 1, 2025 •
edited
Loading

Resolved Issue

PR Description

  • 주석 추가 등 코드 개선 사항을 포함합니다.

Others

  • 기존 ScheduleController에서 ApplicationFormService을 참조하여 엔티티를 넘겨주는 상황이었어서 ScheduleService가 ApplicationFormService을 참조하도록 변경하였으나, (06e02ef) 순환 참조가 발생하여 일단 ScheduleService에서 applicationFormRepository을 직접 참조하는 방식으로 변경하였습니다. 추후 다른 디자인 패턴을 적용할 필요가 있어보입니다. (f1145a2)

@hyotatoFrappuccino hyotatoFrappuccino changed the title docs: 주석 작성 docs docs: 주석 작성 Sep 1, 2025
@hyotatoFrappuccino hyotatoFrappuccino merged commit 24cfb2a into dev Sep 1, 2025
2 checks passed
@hyotatoFrappuccino hyotatoFrappuccino deleted the docs/#78 branch September 1, 2025 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gnsdp99 gnsdp99 gnsdp99 approved these changes

Assignees

@hyotatoFrappuccino hyotatoFrappuccino

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

docs: 주석 작성

3 participants

@hyotatoFrappuccino @gnsdp99