checking if the workflow exist before saving after validation #119
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frikky
reviewed
Oct 24, 2024
Member
frikky
left a comment
frikky
left a comment
There was a problem hiding this comment.
Just remove what should be removed. Don't add even more validation
shared.go
Outdated
| workflow.Validation.ExecutionId = exec.ExecutionId | ||
|
|
||
| // Check if the workflow exist or not before saving (fix after 22/10/24 outage) | ||
| _, err = GetWorkflow(ctx, workflow.ID) |
Member
There was a problem hiding this comment.
Why are we getting the workflow, when we should be removing the SetWorkflow part entirely?
This makes very very little sense. This would require perfect deletion of Cache + Database timing down to the millisecond (or even cllser) with how the outage was
Member
|
@yashsinghcodes don't do You pushed things related to app_upload 👎 |
Member
Author
|
@frikky This is the dumb mistake from my side I thought I have no PR open from fix-outage-issue branch. I will resolve this ASAP. Thank you so much for pointing it out. |
Member
|
Fixed it already |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quick fix after yesterday outage where the workflow was keep recreating due to the validation part.