Set PARAMETER_INDEX for all MethodParameterIn nodes #365
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ml86
requested changes
Jul 1, 2025
Contributor
ml86
left a comment
ml86
left a comment
There was a problem hiding this comment.
Please make a habit of not mixing unrelated things in the same PR. Here you mix the "this" define introduction with the PARAMETER_INDEX setting which is completely unrelated and makes it hard for me to review. Especially these big find and replace style renames i wont accept anymore if they are not completely separate from functional changes. Still acceptable are occasional typo fixes but it has to minor relative to the main PR topic.
src/main/scala/io/shiftleft/js2cpg/astcreation/AstNodeBuilder.scala
Outdated
Show resolved
Hide resolved
max-leuthaeuser
force-pushed
the
max/issues8203
branch
from
37cd517 to
ef4dc7b
Compare
ml86
approved these changes
Jul 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For: https://github.com/ShiftLeftSecurity/codescience/issues/8203