Skip to content

Conversation

@max-leuthaeuser
Copy link
Contributor

@max-leuthaeuser max-leuthaeuser commented Jun 26, 2025

  • updated Joern (and more) and was able to get rid of tons of old helper datastructures / helper methods that are in x2cpg now.
  • update the MacOS runner (12 is gone)

- updated Joern (and more) and was able to get rid of tons of old helper datastructures / helper methods that are in x2cpg now.
- remove CLOSURE_ORIGINAL_NAME for ShiftLeftSecurity/codescience#8347
@max-leuthaeuser max-leuthaeuser changed the title Update and removed usage of CLOSURE_ORIGINAL_NAME Updated dependencies and removed usage of CLOSURE_ORIGINAL_NAME Jun 26, 2025
@max-leuthaeuser max-leuthaeuser requested review from ml86 June 26, 2025 14:47
@max-leuthaeuser
Copy link
Contributor Author

There is

Could not load Logmanager "wvlet.log.AirframeLogManager"
java.lang.ClassNotFoundException: wvlet.log.AirframeLogManager

on the MacOS runner coming from sbt. No idea what's going on. It's not crashing though.
@mpollmeier Any idea?

@mpollmeier
Copy link
Contributor

mpollmeier commented Jun 26, 2025

not sure if it's that, but might be worth updating the plugins...
see sbt/sbt#7338

i.e. the version numbers in project/plugins.sbt
specifically sbt-ci-release-early

@mpollmeier
Copy link
Contributor

just pushed something to your branch, take a look if that's better.
not sure if the gitCommitString really isn't required. if it is, I can add the sbt-git plugin back in explicitly...

@max-leuthaeuser
Copy link
Contributor Author

Thanks, the error is gone.

Non idea about the gitCommitString.
Maybe that's used during release?

@mpollmeier
Copy link
Contributor

no idea, don't think so but would prefer not to break anything... so I just added it back in

Copy link
Contributor

@ml86 ml86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please separate the removal of CLOSURE_ORIGINAL_NAME property into a separate PR.

@max-leuthaeuser
Copy link
Contributor Author

max-leuthaeuser commented Jun 30, 2025

Right, I will fix this PR to do the Joern update / adaption only and do a second PR
as soon as joernio/joern#5544 is released to remove all tests w.r.t. CLOSURE_ORIGINAL_NAME. (its only ever set in x2cpg VariableScopeManager and that will be gone with the Joern PR 5554).

edit: Done.

@max-leuthaeuser max-leuthaeuser changed the title Updated dependencies and removed usage of CLOSURE_ORIGINAL_NAME Updated dependencies and adapt API usage Jun 30, 2025
@max-leuthaeuser max-leuthaeuser merged commit f4c98f8 into master Jun 30, 2025
4 checks passed
@max-leuthaeuser max-leuthaeuser deleted the max/updateAndIssues8347 branch June 30, 2025 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants