Skip to content

feat(rapid):revise and support decimal type#716

Merged
ShannonBase merged 1 commit intoShannon-Data:mainfrom
RingsC:revise-shannon-rapid
May 9, 2026
Merged

feat(rapid):revise and support decimal type#716
ShannonBase merged 1 commit intoShannon-Data:mainfrom
RingsC:revise-shannon-rapid

Conversation

@RingsC
Copy link
Copy Markdown
Contributor

@RingsC RingsC commented May 8, 2026

Issues:#642

I hereby agree to the terms of the CLA available at: http://www.shannondata.ai/doc/cla/

Summary

_
Add native DECIMAL type support to PredicateValueType for precise decimal predicate handling in IMCS

Introduce DECIMAL enum value to PredicateValueType Update PredicateValue constructors, comparison operators, and type conversions Update optimizer to create DECIMAL PredicateValues from SEL_ARG and Item evaluations Extend storage index numeric predicate checks to include DECIMAL type.
_

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

@ShannonBase ShannonBase self-requested a review May 8, 2026 09:45
@ShannonBase ShannonBase self-assigned this May 8, 2026
@ShannonBase ShannonBase added enhancement New feature or request feature It will be implemented as a new feature labels May 8, 2026
Copy link
Copy Markdown
Contributor

@ShannonBase ShannonBase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@RingsC RingsC force-pushed the revise-shannon-rapid branch 4 times, most recently from ddbaa51 to 256c2a5 Compare May 9, 2026 04:03
Add native DECIMAL type support to PredicateValueType for precise decimal predicate handling in IMCS

1:Introduce DECIMAL enum value to PredicateValueType
Update PredicateValue constructors, comparison operators, and type conversions
Update optimizer to create DECIMAL PredicateValues from SEL_ARG and Item evaluations
Extend storage index numeric predicate checks to include DECIMAL type

2: add missing compilation params of weekly action.

Issues:#Shannon-Data#642
@RingsC RingsC force-pushed the revise-shannon-rapid branch from 256c2a5 to 4120ab1 Compare May 9, 2026 06:36
@ShannonBase ShannonBase merged commit 62a47b5 into Shannon-Data:main May 9, 2026
6 of 7 checks passed
@RingsC RingsC deleted the revise-shannon-rapid branch May 9, 2026 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request feature It will be implemented as a new feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat(rapid): to support more deciaml in predicate

2 participants