Skip to content

fix(binlog): correct incorrect binlog event handling #710

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ShannonBase merged 1 commit into from
May 4, 2026
+6 −2
Merged

fix(binlog): correct incorrect binlog event handling #710

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions ml/ml_utils.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,7 @@
#include "sql/sql_base.h"
#include "sql/sql_class.h"
#include "sql/table.h"
#include "sql/thd_raii.h"
#include "sql/transaction.h" // trans_commit_stmt

#include "ml_algorithm.h"
Expand Down Expand Up @@ -616,6 +617,8 @@ BoosterHandle Utils::load_trained_model_from_string(std::string &model_content)
int Utils::update_model_in_catalog(TABLE *table, const std::string &model_handle, size_t field_no,
const std::string &field_value) {
THD *thd = current_thd;
Disable_binlog_guard binlog_guard(thd);

if (table->file->ha_external_lock(thd, F_WRLCK)) return HA_ERR_GENERIC;

if (table->file->inited == handler::NONE && table->file->ha_rnd_init(true)) {
Expand Down
2 changes: 1 addition & 1 deletion storage/rapid_engine/handler/ha_shannon_rapid.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2753,7 +2753,7 @@ extern bool srv_is_upgrade_mode;
extern char mysql_home[FN_REFLEN];
extern char mysql_llm_home[FN_REFLEN];
extern bool opt_initialize;
extern bool opt_upgrade_mode;
extern long opt_upgrade_mode;
static int Shannonbase_Rapid_Init(MYSQL_PLUGIN p) {
ShannonBase::shannon_loaded_tables = new ShannonBase::LoadedTables();

Expand Down
3 changes: 2 additions & 1 deletion storage/rapid_engine/optimizer/rules/rule.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,9 +31,10 @@
#include "storage/rapid_engine/optimizer/query_plan.h"
class Query_expression;
class Query_block;
class CostEstimator;

namespace ShannonBase {
namespace Optimizer {
class CostEstimator;
/**
* Base class for optimization rules
*/
Expand Down
Loading