feat: refactor RPM to be closer to a fedora package #481
Conversation
This basically just cleans up the RPM package somewhat, less stuff specific to the RPM, so less maintenance IG, also it uses better macros for things now :) Upon checking the rootfses, I get this result: ``` [root@e957e20caa3b tmp]# diff new.txt old.txt 3d2 < ./inputplumber-0.69.1-0.fc43.x86_64.rpm.cpio 8,10d6 < ./usr/lib/.build-id < ./usr/lib/.build-id/75 < ./usr/lib/.build-id/75/3bee4f8b84531764692d561c9041abc5a27db2 26,28d21 < ./usr/share/doc < ./usr/share/doc/inputplumber < ./usr/share/doc/inputplumber/README.md ``` `README.md` is now there and everything else is the exact same Signed-off-by: Tulip Blossom <[email protected]>
|
Note that I've also removed the postinstall scripts since those are usually not a good idea (and also break on container image builds) |
|
And also removed the |
pastaq
left a comment
pastaq
left a comment
There was a problem hiding this comment.
One minor nit that we missed before
…to be accurate to how GNU make works Signed-off-by: Tulip Blossom <[email protected]>
|
Looks good, thanks for doing this. The only outstanding possible issue is the use of feat/fix in the commit messages. Normally when dealing with accessory/build config changes we just use chore and bundle the changes with the next version with changes to the src. As it currently stands this will trigger an new version that has no impact on the binary source code, which would be pretty pointless for non fedora users. I'd like @ShadowApex to weigh in on that though and I'll defer to his judgement on it. |
2 participants
This basically just cleans up the RPM package a bit, less stuff
specific to the RPM, so less maintenance IG, also it uses better macros
for things now :)
Upon checking the rootfses, I get this result:
README.mdis now there and everything else is the exact same