Skip to content

Conversation

Copy link

Copilot AI commented Aug 21, 2025

Problem

The getServoyVersion() method in VersionInfo class had inconsistent visibility compared to other getter methods in the same class. While all other getters were declared as public, this method was package-private:

// Inconsistent - package-private
String getServoyVersion() {
    return servoyVersion;
}

// All other getters are public
public int getBuildNumber() { ... }
public int getRepositoryVersion() { ... }
public byte[] getDigest() { ... }

Solution

Made getServoyVersion() public to maintain consistency with the other getter methods in the class:

public String getServoyVersion() {
    return servoyVersion;
}

This change ensures a consistent public API for all version information accessors and follows the established pattern in the class.

Impact

  • No breaking changes - Only expands visibility from package-private to public
  • Improved API consistency - All version getters now have the same visibility
  • Better encapsulation - Provides proper public access to version information

This is a minor but important consistency fix that improves the overall API design of the VersionInfo class.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • developer.servoy.com
    • Triggering command: /usr/lib/jvm/temurin-17-jdk-amd64/bin/java --enable-native-access=ALL-UNNAMED -classpath /usr/share/apache-maven-3.9.11/boot/plexus-classworlds-2.9.0.jar -Dclassworlds.conf=/usr/share/apache-maven-3.9.11/bin/m2.conf -Dmaven.home=/usr/share/apache-maven-3.9.11 -Dlibrary.jansi.path=/usr/share/apache-maven-3.9.11/lib/jansi-native -Dmaven.multiModuleProjectDirectory=/home/REDACTED/work/servoy-client/servoy-client org.codehaus.plexus.classworlds.launcher.Launcher clean compile -q (dns block)
  • repo.eclipse.org
    • Triggering command: /usr/lib/jvm/temurin-17-jdk-amd64/bin/java --enable-native-access=ALL-UNNAMED -classpath /usr/share/apache-maven-3.9.11/boot/plexus-classworlds-2.9.0.jar -Dclassworlds.conf=/usr/share/apache-maven-3.9.11/bin/m2.conf -Dmaven.home=/usr/share/apache-maven-3.9.11 -Dlibrary.jansi.path=/usr/share/apache-maven-3.9.11/lib/jansi-native -Dmaven.multiModuleProjectDirectory=/home/REDACTED/work/servoy-client/servoy-client org.codehaus.plexus.classworlds.launcher.Launcher clean compile -q (dns block)

If you need me to access, download, or install something from one of these locations, you can either:


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Copilot AI changed the title [WIP] Review this commit Fix VersionInfo.getServoyVersion() visibility inconsistency Aug 21, 2025
Copilot AI requested a review from jcompagner August 21, 2025 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants