SSM debugging and TP prequisites #335
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jlamypoirier
requested review from
RaymondLi0 and
oleksost
and removed request for
RaymondLi0
oleksost
reviewed
Jul 28, 2025
| self.in_proj = nn.Linear( | ||
| self.d_model, 2 * self.d_xb + 2 * self.d_inner + self.dt_rank, bias=bias, **factory_kwargs | ||
| ) | ||
| self.in_proj = nn.Linear(self.d_model, 2 * self.d_xb + 2 * self.d_inner, bias=bias, **factory_kwargs) |
There was a problem hiding this comment.
Seems like this separation is necessary to enable TP. Yet, it would not be backward compatible with exiting m2 checkpoints and requires manually changing the existing checkpoints' state dictionaries to work with this.
There was a problem hiding this comment.
That's correct, but my understanding is that there isn't any such checkpoint yet that we want to keep?
There was a problem hiding this comment.
I had some checkpoints I trained with previous code. I manually altered the state dict, so I think it should be ok.
jlamypoirier
requested review from
oleksost,
nandahkrishna,
nitsanluke,
tscholak and
bigximik
oleksost
approved these changes
Aug 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✨ Description
Make the transformer debugging tools available to SSMs, mainly through a base Mixer class. Bring the breaking changes for Mamba2 here to enable direct model comparison (Separate the first dt layer, fix initialization).
Also brought some extra changes from #333, it was simpler to do and will help reduce the size of that PR.