Skip to content

Ensure with pre-install hook the Secret is not overwritten #242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
roberth1988 wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Ensure with pre-install hook the Secret is not overwritten #242

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
24eb39d
Ensure with pre-install hook the Secret is not overwritten
Jul 4, 2025
9219e4d
Merge branch 'Sentinel-One:master' into task/ensure-helper-secret-is-…
roberth1988 Jul 11, 2025
589f6c8
This change allows proper upgrade too on existing
Jul 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions charts/s1-agent/templates/common/secrets.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,9 @@ kind: Secret
metadata:
name: {{ include "helper.secret.name" . }}
labels: {{- include "sentinelone.helper.labels" . | nindent 4 }}
annotations:
Copy link
Copy Markdown
Collaborator

@oded-s1 oded-s1 Feb 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@roberth1988 can you elaborate on the motivation for this change?
Do you happen to know if the secret will be deleted after uninstall?

"helm.sh/hook": pre-install
"helm.sh/hook-delete-policy": "before-hook-creation"
type: kubernetes.io/tls
data: {{- include "helper.certificates" . | nindent 2 }}
{{- end }}
Expand Down