Skip to content

fix/annotation-list-class-order#245

Merged
TrevorBurgoyne merged 2 commits into
mainfrom
fix/anno-list-class-order
May 11, 2026
Merged

fix/annotation-list-class-order#245
TrevorBurgoyne merged 2 commits into
mainfrom
fix/anno-list-class-order

Conversation

@TrevorBurgoyne
Copy link
Copy Markdown
Member

@TrevorBurgoyne TrevorBurgoyne commented May 11, 2026

fix/annotation-list-class-order

Description

  • Fix AnnotationList class ordering to match the AnnotationID toolbox item ordering, which is based on the configured class definition order in the subtask's classes array
  • Add local storage of checkbox options for the AnnotationList toolbox item

PR Checklist

  • Merged latest main
  • Version number in package.json has been bumped since last release
  • Version numbers match between package package.json and src/version.js
  • Updated documentation if necessary (currently just in api_spec.md)
  • Added changes to changelog.md

Breaking API Changes

AnnotationList class ordering is now based on the subtask order and not class id

@TrevorBurgoyne TrevorBurgoyne added the bug Something isn't working label May 11, 2026
@TrevorBurgoyne TrevorBurgoyne requested a review from Copilot May 11, 2026 16:13
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the AnnotationList toolbox item to render class-group headers in a deterministic order that matches the configured class definition order, and adds persistence for the list’s checkbox UI options via localStorage.

Changes:

  • Render grouped class headers in AnnotationList based on subtask.class_defs order (with a fallback for unknown/orphan class IDs).
  • Persist and restore show_deprecated + group_by_class checkbox states in localStorage.
  • Add an e2e test that asserts grouped header ordering follows class_defs order (including after a runtime reversal).

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
tests/e2e/annotation_list.spec.js Adds an e2e regression test for class-group header ordering.
src/toolbox_items/annotation_list.ts Implements class_defs-ordered grouping and persists/restores checkbox state via localStorage.
CHANGELOG.md Adds release notes for 0.23.6.
src/version.js Bumps runtime version constant to 0.23.6.
package.json Bumps package version to 0.23.6.

Comment thread src/toolbox_items/annotation_list.ts
Comment thread CHANGELOG.md Outdated
Comment thread src/toolbox_items/annotation_list.ts
@TrevorBurgoyne TrevorBurgoyne merged commit 1dcbafd into main May 11, 2026
4 checks passed
@TrevorBurgoyne TrevorBurgoyne deleted the fix/anno-list-class-order branch May 11, 2026 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants