Skip to content

Fix/issue70#72

Open
LuvMangorange wants to merge 4 commits intoSenteraLLC:mainfrom
LuvMangorange:fix/issue70
Open

Fix/issue70#72
LuvMangorange wants to merge 4 commits intoSenteraLLC:mainfrom
LuvMangorange:fix/issue70

Conversation

@LuvMangorange
Copy link
Copy Markdown

… correctly in ODM.

FIX: Radiometrically corrected M3M images fail to mosaic correctly in ODM. #70

What?

Relative radiometric correction of M3M multispectral images leads to incorrect output during mosaicing in ODM. ODM supports relative correction natively but lacks absolute correction support. Fixing this issue will enable seamless integration between this project and ODM.

Why?

The issue occurs because the metadata handling for DJI Mavic 3M (M3M) sensors was not properly aligned with ODM's expectations. When radiometrically correcting M3M images, the current implementation sets specific band parameters (wavelength, FWHM) directly in the EXIF metadata, but ODM requires these values to be stored in XMP-Camera namespace tags for proper mosaic processing.

The fix ensures that M3M images retain the necessary metadata structure that ODM expects, while still benefiting from the radiometric correction provided by this project.

PR Checklist

  • [✓] Merged latest master
  • [✓] Updated version number
  • [✓] All private git packages are at their newest version in both pyproject.toml and environment.yml
  • [✓] All git package version numbers match between pyproject.toml and environment.yml
  • [✓] dist/ImageryCorrector.exe and dist/GetCorrectionsCsv.exe have been rebuilt

Breaking Changes

This fix modifies the metadata structure for M3M images to ensure compatibility with ODM. While the changes are focused on metadata formatting and should not affect the core radiometric correction functionality, users who rely on the specific EXIF tag structure for other workflows may need to adjust their downstream processes.

@joeyfranck56
Copy link
Copy Markdown
Contributor

@LuvMangorange I will find some time this week to take a closer look at this issue with ODM.

@LuvMangorange
Copy link
Copy Markdown
Author

@LuvMangorange I will find some time this week to take a closer look at this issue with ODM.
Thanks. The code modifications submitted currently support relative radiometric correction. After correction, seamless mosaicking can be directly carried out using ODM. Subsequently, code for general non - Sentera calibration plate recognition will be continuously added, enabling direct absolute radiometric correction, and then seamless connection to ODM for mosaicking.

1 similar comment
@LuvMangorange
Copy link
Copy Markdown
Author

@LuvMangorange I will find some time this week to take a closer look at this issue with ODM.
Thanks. The code modifications submitted currently support relative radiometric correction. After correction, seamless mosaicking can be directly carried out using ODM. Subsequently, code for general non - Sentera calibration plate recognition will be continuously added, enabling direct absolute radiometric correction, and then seamless connection to ODM for mosaicking.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants