Report error state when out of sync#67
Merged
Merged
Conversation
…vered - Logs out of sync/resync events
Contributor
There was a problem hiding this comment.
Pull request overview
Implements protocol-required client state transitions for sync loss/recovery in the sync task, adding explicit ERROR reporting when playback falls out of sync and SYNCHRONIZED when alignment is regained, with logging around these transitions.
Changes:
- Add
SyncContextflags to track alignment phases and edge-triggerERROR/SYNCHRONIZEDtransitions. - Emit
client/state=ERRORonce when sync is lost (outside alignment phases), andclient/state=SYNCHRONIZEDwhen in-tolerance sync is regained. - Mark post-seek periods as “aligning” to avoid reporting expected hard-sync behavior as an error.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/sync_task.h | Adds aligning / reported_error flags to track alignment lifecycle and state transition edges. |
| src/sync_task.cpp | Reports ERROR on out-of-sync, reports SYNCHRONIZED on recovery, and treats post-seek as an expected alignment phase. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Report error state when out of sync and report synchronized when recovered. Logs out of sync/resync events. This is required by the spec (https://github.com/Sendspin/spec/blob/133383e588bbf1ddcfcf9952626ede0bcdef79a3/README.md?plain=1#L175)
Closes #63