Acknowledge incorrect automated review comment on NUM_PROMPTS calculation#243
Closed
Copilot wants to merge 1 commit intorefactor-docker-runner-launchfrom
Closed
Acknowledge incorrect automated review comment on NUM_PROMPTS calculation#243Copilot wants to merge 1 commit intorefactor-docker-runner-launchfrom
Copilot wants to merge 1 commit intorefactor-docker-runner-launchfrom
Conversation
Copilot
AI
changed the title
[WIP] Update Docker runner refactor for better clarity and structure
Acknowledge incorrect automated review comment on NUM_PROMPTS calculation
Nov 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addressed review comment flagging that
NUM_PROMPTSwas not calculated before the docker run command inlaunch_b200-nvd.sh.The automated review was incorrect -
NUM_PROMPTSis properly calculated on lines 28-36 before being passed to the docker container on line 45, using identical logic tolaunch_mi355x-amd.sh. No code changes were needed; replied to the comment acknowledging the error in the automated review.💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.