Skip to content

[AMD] Update MiniMax-M3-MXFP4 MI355X vLLM disagg perf and config#1943

Draft
Duyi-Wang wants to merge 1 commit into
mainfrom
feat/minimaxm3-fp4-mi355x-vllm-disagg-exp
Draft

[AMD] Update MiniMax-M3-MXFP4 MI355X vLLM disagg perf and config#1943
Duyi-Wang wants to merge 1 commit into
mainfrom
feat/minimaxm3-fp4-mi355x-vllm-disagg-exp

Conversation

@Duyi-Wang

Copy link
Copy Markdown
Collaborator

Changes

  • Prefill-only INT4 quick-reduce: set VLLM_ROCM_QUICK_REDUCE_QUANTIZATION=INT4 and VLLM_ROCM_QUICK_REDUCE_MAX_SIZE_BYTES_MB=2048 on the prefill workers, via a new prefill_env channel in server_vllm.sh (mirrors the existing decode_env path; injected on every prefill rank). Applied to the MiniMax-M3-MXFP4 entry in models_vllm.yaml.
  • Search space: cap the 1P1D TP4 concurrency sweep at 256 (was 512). 2P1D TP4 unchanged at 128/256/512.

Notes

  • Quick-reduce is prefill-only (the all-reduce path); decode is unaffected.
  • Single commit on top of main; perf-changelog.yaml entry included.

@github-actions

Copy link
Copy Markdown
Contributor

Thanks for the contribution! For vLLM & SGLang, please ensure that your recipes is similar to the official vLLM recipes and/or the SGLang cookbook

If it is not, please create a PR first before we can merge your single node PR into the master branch. Let's ensure that the documentation is first class such that the entire ML community can benefit from your hard work! Thank you

PR authors are responsible for ensuring that after merging, all GitHub Action jobs fully pass. A lot of the time, failures are just flakes and simply re-running the failed jobs will fix it. If re-running failed jobs is attempted, PR authors are responsible for ensuring it passes. See GitHub's docs on re-running failed jobs: https://docs.github.com/en/actions/how-tos/manage-workflow-runs/re-run-workflows-and-jobs#re-running-failed-jobs-in-a-workflow

As a rule of thumb, generally, PR authors should request a review & get a PR approval from the respective companies' CODEOWNERS before requesting a review from core maintainers.

If additional help is needed, PR authors can reach out to core maintainers over Slack.


感谢你的贡献!对于 vLLM 与 SGLang,请确保你的 recipe 与官方 vLLM recipes 和/或 SGLang cookbook 保持一致

如果不一致,请先创建一个 PR,之后我们才能将你的单节点 PR 合并到 master 分支。让我们确保文档保持一流水准,使整个 ML 社区都能从你的辛勤工作中受益!谢谢

PR 作者有责任确保合并后所有 GitHub Action 任务完全通过。 很多时候失败只是偶发抖动(flake),重新运行失败的任务即可解决。如果选择重新运行失败的任务,PR 作者有责任确保其最终通过。参见 GitHub 关于重新运行失败任务的文档:https://docs.github.com/en/actions/how-tos/manage-workflow-runs/re-run-workflows-and-jobs#re-running-failed-jobs-in-a-workflow

一般而言,PR 作者应先向相应公司的 CODEOWNERS 请求审阅并获得 PR 批准,然后再请求核心维护者审阅。

如需更多帮助,PR 作者可通过 Slack 联系核心维护者。

@Duyi-Wang Duyi-Wang force-pushed the feat/minimaxm3-fp4-mi355x-vllm-disagg-exp branch from a8d9eae to 99ff255 Compare June 26, 2026 03:02
@Duyi-Wang Duyi-Wang marked this pull request as ready for review June 26, 2026 03:02
@Duyi-Wang Duyi-Wang requested a review from a team June 26, 2026 03:02
@claude

claude Bot commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

Claude finished @Duyi-Wang's task in 1m 3s —— View job


PR Review

  • Gather context (diff, server_vllm.sh, models_vllm.yaml, perf-changelog.yaml)
  • Verify prefill_env injection mirrors decode_env
  • Validate master-config + perf-changelog rules

LGTM — no blocking issues found.

Verified:

  • The new prefill_env / PREFILL_MODEL_ENVS channel correctly mirrors the existing decode_env path. It's injected on all prefill ranks — node 0 (proxy+prefill, server_vllm.sh:256) and additional prefill nodes 1..xP-1 (server_vllm.sh:430) — before each vllm serve prefill command. The for env_pair in ${PREFILL_MODEL_ENVS}; do export "$env_pair" pattern word-splits the two KEY=VALUE pairs correctly. Decode is untouched, matching the "prefill-only" intent.
  • amd-master.yaml was modified and perf-changelog.yaml was updated — the new entry is correctly appended to the end of the file (after PR [codex] add MiniMax M3 FP4 MI355X vLLM MTP benchmark #1939's entry).
  • The minimaxm3-fp4-mi355x-vllm-disagg config key is pre-existing (only the conc-list was edited 512→256), so no new model-prefix concern introduced here.


# MiniMax-M3 MXFP4 MI355X vLLM disaggregated (prefill/decode) config.
minimaxm3-fp4-mi355x-vllm-disagg:
image: rocm/vllm-dev:vllm-0.23.1-rocm723-mi35x-mori-0625

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can u update this an upstream docker image such that it is a performance update PR? @Duyi-Wang

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, the image will be updated once all optimizations have been merged.

…onc at 256

- models_vllm.yaml: prefill_env (VLLM_ROCM_QUICK_REDUCE_QUANTIZATION=INT4,
  VLLM_ROCM_QUICK_REDUCE_MAX_SIZE_BYTES_MB=2048) for MiniMax-M3-MXFP4.
- server_vllm.sh: prefill_env / PREFILL_MODEL_ENVS channel (mirrors decode_env).
- amd-master.yaml: 1P1D TP4 conc sweep 1..512 -> 1..256 (2P1D unchanged).
@Duyi-Wang Duyi-Wang force-pushed the feat/minimaxm3-fp4-mi355x-vllm-disagg-exp branch from 99ff255 to 305e728 Compare June 26, 2026 03:06
@functionstackx functionstackx marked this pull request as draft June 26, 2026 03:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

2 participants