[AMD] Update MiniMax-M3-MXFP4 MI355X vLLM disagg perf and config#1943
[AMD] Update MiniMax-M3-MXFP4 MI355X vLLM disagg perf and config#1943Duyi-Wang wants to merge 1 commit into
Conversation
|
Thanks for the contribution! For vLLM & SGLang, please ensure that your recipes is similar to the official vLLM recipes and/or the SGLang cookbook If it is not, please create a PR first before we can merge your single node PR into the master branch. Let's ensure that the documentation is first class such that the entire ML community can benefit from your hard work! Thank you PR authors are responsible for ensuring that after merging, all GitHub Action jobs fully pass. A lot of the time, failures are just flakes and simply re-running the failed jobs will fix it. If re-running failed jobs is attempted, PR authors are responsible for ensuring it passes. See GitHub's docs on re-running failed jobs: https://docs.github.com/en/actions/how-tos/manage-workflow-runs/re-run-workflows-and-jobs#re-running-failed-jobs-in-a-workflow As a rule of thumb, generally, PR authors should request a review & get a PR approval from the respective companies' CODEOWNERS before requesting a review from core maintainers. If additional help is needed, PR authors can reach out to core maintainers over Slack. 感谢你的贡献!对于 vLLM 与 SGLang,请确保你的 recipe 与官方 vLLM recipes 和/或 SGLang cookbook 保持一致 如果不一致,请先创建一个 PR,之后我们才能将你的单节点 PR 合并到 master 分支。让我们确保文档保持一流水准,使整个 ML 社区都能从你的辛勤工作中受益!谢谢 PR 作者有责任确保合并后所有 GitHub Action 任务完全通过。 很多时候失败只是偶发抖动(flake),重新运行失败的任务即可解决。如果选择重新运行失败的任务,PR 作者有责任确保其最终通过。参见 GitHub 关于重新运行失败任务的文档:https://docs.github.com/en/actions/how-tos/manage-workflow-runs/re-run-workflows-and-jobs#re-running-failed-jobs-in-a-workflow 一般而言,PR 作者应先向相应公司的 CODEOWNERS 请求审阅并获得 PR 批准,然后再请求核心维护者审阅。 如需更多帮助,PR 作者可通过 Slack 联系核心维护者。 |
a8d9eae to
99ff255
Compare
|
Claude finished @Duyi-Wang's task in 1m 3s —— View job PR Review
LGTM — no blocking issues found. Verified:
|
|
|
||
| # MiniMax-M3 MXFP4 MI355X vLLM disaggregated (prefill/decode) config. | ||
| minimaxm3-fp4-mi355x-vllm-disagg: | ||
| image: rocm/vllm-dev:vllm-0.23.1-rocm723-mi35x-mori-0625 |
There was a problem hiding this comment.
can u update this an upstream docker image such that it is a performance update PR? @Duyi-Wang
There was a problem hiding this comment.
Ok, the image will be updated once all optimizations have been merged.
…onc at 256 - models_vllm.yaml: prefill_env (VLLM_ROCM_QUICK_REDUCE_QUANTIZATION=INT4, VLLM_ROCM_QUICK_REDUCE_MAX_SIZE_BYTES_MB=2048) for MiniMax-M3-MXFP4. - server_vllm.sh: prefill_env / PREFILL_MODEL_ENVS channel (mirrors decode_env). - amd-master.yaml: 1P1D TP4 conc sweep 1..512 -> 1..256 (2P1D unchanged).
99ff255 to
305e728
Compare
Changes
VLLM_ROCM_QUICK_REDUCE_QUANTIZATION=INT4andVLLM_ROCM_QUICK_REDUCE_MAX_SIZE_BYTES_MB=2048on the prefill workers, via a newprefill_envchannel inserver_vllm.sh(mirrors the existingdecode_envpath; injected on every prefill rank). Applied to theMiniMax-M3-MXFP4entry inmodels_vllm.yaml.Notes
main;perf-changelog.yamlentry included.