[FEAT] 임박한 공연 조회

[sweatbuckets]

1. #⃣ 연관된 이슈
   • 관련 이슈를 명시해주세요.
   • 예: #이슈번호, #이슈번호
2. 📝 작업 내용
   • 이번 PR에서 작업한 내용을 간략히 설명해주세요.
   • 필요한 경우 이미지 첨부 가능.
3. 📸 스크린샷 (선택)
   • 작업 내용을 시각적으로 표현할 스크린샷을 포함하세요.
4. 💬 리뷰 요구사항 (선택)
   • 리뷰어가 특히 검토해주었으면 하는 부분이 있다면 작성해주세요.
   • 예: "메서드 XXX의 이름을 더 명확히 하고 싶은데, 좋은 아이디어가 있으신가요?"

Summary by CodeRabbit

• New Features
  • Added capability to retrieve and view upcoming shows in the system.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[coderabbitai]

📝 Walkthrough

Walkthrough

A new GET /incoming endpoint was added to AmateurController that retrieves upcoming amateur shows for the authenticated member by delegating to amateurService.getShowToday(member.getId()), with response wrapped in an ApiResponse containing a list of AmateurShowResponseDTO.AmateurShowList objects.

Changes

Cohort / File(s)	Summary
New API Endpoint src/main/java/cc/backend/amateurShow/controller/AmateurController.java	Added getShowIncoming() method to handle GET /incoming requests; returns upcoming amateur shows for the current member; annotated with @Operation(summary = "임박한 공연 조회 API") and delegates to amateurService.getShowToday(member.getId())

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

• [FIX] 메서드 이름 수정및 페이지 크기 조절 #129 — Adds a different GET /incoming endpoint implementation that calls amateurService.getRecentlyHotShow() instead of getShowToday(), creating a potential conflict with this PR's endpoint.
• [FIX] controller 메서드 정리 #128 — Directly removes or comments out the getShowIncoming() method that this PR is introducing, indicating a direct conflict in the same controller method.

Poem

🐰 A fresh endpoint hops into place,
Incoming shows at a brisk pace,
Delegating to service with care,
Upcoming performances to share! ✨

Pre-merge checks and finishing touches

❌ Failed checks (2 warnings)

Check name	Status	Explanation	Resolution
Description check	⚠️ Warning	The PR description is entirely a blank template with no actual content—all required and optional sections lack substantive information about the changes made.	Fill in the description with: related issue numbers, a summary of the new /incoming endpoint and its purpose, optional screenshots, and any review requests.
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	You can run @coderabbitai generate docstrings to improve docstring coverage.

✅ Passed checks (1 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title '[FEAT] 임박한 공연 조회' directly corresponds to the main change—adding a GET /incoming API endpoint to retrieve upcoming performances.

✨ Finishing touches

• 📝 Generate docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 1

📜 Review details

Configuration used: defaults

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 013cc1b and 0b98edd.

📒 Files selected for processing (1)

• src/main/java/cc/backend/amateurShow/controller/AmateurController.java

[coderabbitai]

⚠️ Potential issue | 🔴 Critical

🧩 Analysis chain

🏁 Script executed:

# Find AmateurService file
fd -t f "AmateurService" --type java

Repository: SeeATheater/CC_Backend

Length of output: 237

---

🏁 Script executed:

# Search for getShowIncoming method across the codebase
rg -nP --type=java 'getShowIncoming' -i

Repository: SeeATheater/CC_Backend

Length of output: 290

---

🏁 Script executed:

# Also check for getShowToday method to understand its implementation
rg -nP --type=java 'getShowToday' -A5

Repository: SeeATheater/CC_Backend

Length of output: 3153

---

🏁 Script executed:

# Find and display the AmateurService interface
find . -name "AmateurService.java" -not -path "*/Impl.java"

Repository: SeeATheater/CC_Backend

Length of output: 151

---

🏁 Script executed:

# Read the interface file to see all method signatures
cat src/main/java/cc/backend/amateurShow/service/amateurShowService/AmateurService.java

Repository: SeeATheater/CC_Backend

Length of output: 1792

---

Logic mismatch: endpoint calls wrong service method.

The /incoming endpoint is documented as "임박한 공연 조회 API" (imminent/upcoming performance lookup), but it calls amateurService.getShowToday(member.getId()) which retrieves today's performances.

No getShowIncoming() method exists in AmateurService, and the /today endpoint (lines 71-75) calls the identical service method, creating functional duplication. The endpoint returns the same data as /today, which is inconsistent with its documented purpose.

Expected behavior: This endpoint should call a different service method that retrieves incoming/imminent performances, or the method needs to be implemented if missing.

🤖 Prompt for AI Agents

In src/main/java/cc/backend/amateurShow/controller/AmateurController.java around
lines 98-102, the /incoming endpoint currently calls
amateurService.getShowToday(member.getId()) which returns today's shows
(duplicating /today) instead of imminent/upcoming shows; update the controller
to call the correct service method (e.g.,
amateurService.getShowIncoming(member.getId())) or, if that method does not
exist, implement a new service method getShowIncoming(Long memberId) in
AmateurService that returns the imminent performances (define the time
window/criteria there), and then have the controller call that new method and
return its result.