Skip to content

Conversation

@sweatbuckets
Copy link
Contributor

@sweatbuckets sweatbuckets commented Dec 31, 2025

  1. #⃣ 연관된 이슈
    • 관련 이슈를 명시해주세요.
    • 예: #이슈번호#이슈번호
  2. 📝 작업 내용
    • 이번 PR에서 작업한 내용을 간략히 설명해주세요.
    • 필요한 경우 이미지 첨부 가능.
  3. 📸 스크린샷 (선택)
    • 작업 내용을 시각적으로 표현할 스크린샷을 포함하세요.
  4. 💬 리뷰 요구사항 (선택)
    • 리뷰어가 특히 검토해주었으면 하는 부분이 있다면 작성해주세요.
    • 예: "메서드 XXX의 이름을 더 명확히 하고 싶은데, 좋은 아이디어가 있으신가요?"

Summary by CodeRabbit

  • API Changes
    • Show ranking endpoint now retrieves recently popular shows instead of standard ranking data.
    • The incoming shows endpoint has been removed and is no longer available.

✏️ Tip: You can customize this high-level summary in your review settings.

@sweatbuckets sweatbuckets merged commit 6f763b1 into develop Dec 31, 2025
1 of 2 checks passed
@coderabbitai
Copy link

coderabbitai bot commented Dec 31, 2025

Caution

Review failed

The pull request is closed.

📝 Walkthrough

Walkthrough

The AmateurController's ranking endpoint is refactored to call amateurService.getRecentlyHotShow() instead of getShowRanking(), effectively changing its data source. The getShowIncoming endpoint mapped to "/incoming" is removed, disabling that API path.

Changes

Cohort / File(s) Change Summary
API Endpoint Modification
src/main/java/cc/backend/amateurShow/controller/AmateurController.java
The getShowRanking method now calls amateurService.getRecentlyHotShow(member.getId()) instead of amateurService.getShowRanking(member.getId()), changing the underlying data source for the ranking API. The getShowIncoming endpoint is removed (commented out), disabling the "/incoming" API path.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Possibly related PRs

  • SeeATheater/CC_Backend#127: Renames and repurposes getIncomingShow() to getRecentlyHotShow() in the service layer, which directly aligns with this controller's switch to call the newly renamed service method.

Poem

🐰 The shows must flow in different ways,
From incoming dreams to recent blaze,
One path is dimmed, another bright,
The ranking sways toward the light! ✨

✨ Finishing touches
  • 📝 Generate docstrings

📜 Recent review details

Configuration used: defaults

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between e8ffa83 and 931f75d.

📒 Files selected for processing (1)
  • src/main/java/cc/backend/amateurShow/controller/AmateurController.java

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai coderabbitai bot mentioned this pull request Jan 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants