feat: sort by rating

[michaeliuedu]

give user choice to sort by rating (highest to lowest or lowest to highest) or by the default times. i added a placeholder dropdown for this. also commits are kinda messy sorry

[vercel]

@michaeliuedu is attempting to deploy a commit to the ScottyLabs Team on Vercel.

A member of the Team first needs to authorize it.

[Copilot]

Pull request overview

Adds a user-facing sort control to the list view (time vs rating) by fetching per-location review summaries and threading rating data through the location model, alongside some related UI/API cleanup (report endpoint + banner refactor).

Changes:

• Add a sort dropdown on the List page and support sorting cards by rating (asc/desc) or existing time-based ordering.
• Fetch review summary data per location and attach averageRating/ratingCount onto ILocation_Full.
• Refactor the top banner into a reusable GeneralBanner and update the report API schema/usage.

Reviewed changes

Copilot reviewed 13 out of 21 changed files in this pull request and generated 8 comments.

Show a summary per file

File	Description
src/util/storage.ts	Minor formatting fix.
src/util/queryLocations.ts	Import formatting only.
src/types/locationTypes.ts	Add rating data types and extend ILocation_Full.
src/types/api.d.ts	Update generated API types (report payload, new reports endpoint).
src/pages/ListPage.tsx	Add sort control + click-to-close-drawer behavior; refactor into ListBox.
src/index.css	Add --red-700 color token.
src/components/banners/GeneralBanner.tsx	Generalize banner into reusable component with configurable text + storage key.
src/components/banners/GeneralBanner.module.css	Minor CSS tweak (top: 0).
src/components/SelectSort.tsx	New sort <select> control.
src/components/SelectLocation.tsx	Formatting-only change.
src/components/EateryCardHeader.tsx	Update report UI copy and align POST body with updated API.
src/components/EateryCardHeader.module.css	Update report button colors/hover token.
src/components/EateryCardGrid.tsx	Implement rating-based sort option.
src/components/EateryCardGrid.module.css	Formatting-only change.
src/components/EateryCardContent.tsx	Formatting-only change.
src/components/EateryCardContent.module.css	Formatting-only change.
src/components/EateryCard.tsx	Formatting-only change.
src/components/EateryCard.module.css	Formatting-only change.
src/App.tsx	Fetch ratings via React Query useQueries and pass into full location objects; swap to GeneralBanner.
src/App.css	Fix mobile layout rules by moving them into a top-level media query.
api.yaml	Update /report schema + add /v2/locations/{locationId}/reports endpoint.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

toast.error(Failed to submit report: ${error}) will usually render as [object Object] (or otherwise leak unstructured details) because error is not guaranteed to be a user-friendly string. Keep the toast message human-readable (e.g., generic failure or error.message when available) and rely on console.error/logging for the full error object.

Suggested change

	toast.error(`Failed to submit report: ${error}`);
	const errorMessage =
	typeof error === 'string'
	? error
	: (error as { message?: string })?.message ||
	'An unexpected error occurred while submitting your report.';
	toast.error(`Failed to submit report: ${errorMessage}`);

[Copilot]

type: Date is not a valid OpenAPI Schema Object type value (OpenAPI only supports string/number/integer/boolean/object/array/null). Since you already allow date-time/date strings and numbers, removing the type: Date branch (or converting it to a string with an appropriate format) will keep the spec/tooling valid.

Suggested change

	- type: Date
	- format: date-time
	type: string
	- format: date
	type: string
	- type: string
	format: date-time
	- type: string
	format: date

[Copilot]

Disabling jsx-a11y/no-static-element-interactions and click-events-have-key-events for the entire file hides legitimate accessibility regressions. Prefer addressing the specific interaction (e.g., move the outside-click handler to a dedicated overlay/button, or add proper role/tabIndex + keyboard handling) and scope any lint disable to the smallest possible block.

[Arom1a]

Thanks for your work on this! Could you push your branch directly to this repo instead your forked repo? This way the vercel will automatically deploy the branch without extra authorization issue.

[michaeliuedu]

Thanks for your work on this! Could you push your branch directly to this repo instead your forked repo? This way the vercel will automatically deploy the branch without extra authorization issue.

thanks! i tried pushing my branch directly upstream, but i have a 403 permission error, so i dont think i have write access. is there any way i could receive access to do so?

[Arom1a]

Which specific command have you run? Could you try this one: git push -u upstream sort-by-rating? If it still gives u an error, I will go ask Eric to set your permissions in this repo.

[Arom1a]

After you have successfully pushed to this repo, you can close this pr and open a new one from the branch you pushed to this repo.

[michaeliuedu]

I tried git push -u upstream sort-by-rating, and I’m still getting a 403 permission error: Permission to ScottyLabs/cmueats.git denied to michaeliuedu. So it looks like I still don’t have push access to the repo.

[Arom1a]

Got it

[michaeliuedu]

okay i seem to have access and pushed it