uutils-coreutils@0.10.0: add timeout.exe shim - #8360
Open
God-damnit-all wants to merge 1 commit into
Open
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
Summary by CodeRabbit
WalkthroughThe Scoop manifest adds the Changesuutils timeout support
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
Author
|
/verify (I often forget to do this, sorry about that.) |
Contributor
|
All changes look good. Wait for review from human collaborators. uutils-coreutils
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
uutils coreutils 0.10.0 now has a Windows implementation for
timeout, so it has been included.<manifest-name[@version]|chore>: <general summary of the pull request>As an aside to anyone who reviews this: I'm thinking of doing a PR that changes the
uutils.exeshim here touutils-coreutils.exe(it made sense back when coreutils was pretty much all uutils put out but now they have several things, it's like having amicrosoft.exeshim).Similarly, I want to make the uutils shim in the microsoft implementation of coreutils named
microsoft-coreutils.exeinstead ofuutils.exe(I think this was the result of a copy-and-paste).Let me know if you think this is a good idea.