atac: Persist user data - #8340
Merged
z-Fng merged 3 commits intoJul 29, 2026
Merged
Conversation
Point ATAC_MAIN_DIR at the Scoop persist folder so collections and config survive upgrades. Closes ScoopInstaller#6820. Signed-off-by: Alex Chen <l46983284@gmail.com>
Contributor
Author
|
/verify |
Contributor
|
All changes look good. Wait for review from human collaborators. atac
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
Summary by CodeRabbit
WalkthroughChangesATAC persistence
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Updated notes to include details about config data persistence and directory changes.
Contributor
|
/verify |
Contributor
|
All changes look good. Wait for review from human collaborators. atac
|
z-Fng
approved these changes
Jul 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prerequisites
<manifest-name[@version]|chore>: <general summary of the pull request>Summary
ATAC stores collections/config in the app directory chosen by
--directoryorATAC_MAIN_DIR. The current Main manifest never sets either, so data lands outside Scoop's persist tree and is lost on upgrade.This sets:
env_set.ATAC_MAIN_DIR→$persist_dirpre_installto ensure the persist directory existsnotesline for usersVersion/hashes/autoupdate are unchanged.
Closes #6820
Test Plan
--directoryandATAC_MAIN_DIR(src/cli/args.rs)/verify)