Skip to content

atac: Persist user data - #8340

Merged
z-Fng merged 3 commits into
ScoopInstaller:masterfrom
l46983284-cpu:fix/atac-persist-directory
Jul 29, 2026
Merged

atac: Persist user data#8340
z-Fng merged 3 commits into
ScoopInstaller:masterfrom
l46983284-cpu:fix/atac-persist-directory

Conversation

@l46983284-cpu

Copy link
Copy Markdown
Contributor

Prerequisites

  • Use conventional PR title: <manifest-name[@version]|chore>: <general summary of the pull request>
  • I have read the Contributing Guide

Summary

ATAC stores collections/config in the app directory chosen by --directory or ATAC_MAIN_DIR. The current Main manifest never sets either, so data lands outside Scoop's persist tree and is lost on upgrade.

This sets:

  • env_set.ATAC_MAIN_DIR$persist_dir
  • pre_install to ensure the persist directory exists
  • a short notes line for users

Version/hashes/autoupdate are unchanged.

Closes #6820

Test Plan

  • Confirmed upstream CLI accepts --directory and ATAC_MAIN_DIR (src/cli/args.rs)
  • Manifest JSON still validates structurally (single-file scope)
  • Windows scoop install/update smoke (maintainer CI /verify)

Point ATAC_MAIN_DIR at the Scoop persist folder so collections and
config survive upgrades. Closes ScoopInstaller#6820.

Signed-off-by: Alex Chen <l46983284@gmail.com>
@l46983284-cpu

Copy link
Copy Markdown
Contributor Author

/verify

@github-actions

Copy link
Copy Markdown
Contributor

All changes look good.

Wait for review from human collaborators.

atac

  • Lint
  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

Check the full log for details.

@coderabbitai

coderabbitai Bot commented Jul 24, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: c284757b-6232-4e86-b1b2-3ab0f40f5861

📥 Commits

Reviewing files that changed from the base of the PR and between bad720e and aba8a27.

📒 Files selected for processing (1)
  • bucket/atac.json

Summary by CodeRabbit

  • New Features
    • Added persistent configuration support for ATAC installations.
    • Configuration is now stored in the Scoop persistence directory through the ATAC_MAIN_DIR environment variable.
    • Added upgrade notes explaining the configuration path change introduced in version 0.23.0.

Walkthrough

Changes

ATAC persistence

Layer / File(s) Summary
Configure ATAC persistence
bucket/atac.json
Documents the v0.23.0 configuration path change, sets ATAC_MAIN_DIR to $persist_dir\config, and marks config for persistence.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title is concise, conventional, and accurately summarizes the manifest persistence change.
Description check ✅ Passed The description includes summary, linked issue closure, prerequisites, and test plan, matching the template closely.
Linked Issues check ✅ Passed The manifest now persists ATAC data through Scoop's persist dir, satisfying #6820's requirement to retain settings across upgrades.
Out of Scope Changes check ✅ Passed The diff stays focused on ATAC persistence and notes, with no unrelated code changes.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1


ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 2ea79f26-4d26-4ef9-b46a-7a2ee5f54594

📥 Commits

Reviewing files that changed from the base of the PR and between a95b3c7 and bad720e.

📒 Files selected for processing (1)
  • bucket/atac.json

Comment thread bucket/atac.json Outdated
@z-Fng z-Fng changed the title atac: persist app directory via ATAC_MAIN_DIR atac: Persist user data Jul 29, 2026
z-Fng added 2 commits July 29, 2026 17:17
Updated notes to include details about config data persistence and directory changes.
@z-Fng

z-Fng commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

/verify

@github-actions

Copy link
Copy Markdown
Contributor

All changes look good.

Wait for review from human collaborators.

atac

  • Lint
  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

Check the full log for details.

@z-Fng
z-Fng merged commit 39fecf6 into ScoopInstaller:master Jul 29, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: ATAC doesn't persist in scoop persist folder

2 participants